Skip to content

fix: add multisig_address_book source to v2 calldata local address resolution#273

Merged
fsamier merged 2 commits intomainfrom
fix/v2-multisig-address-book
Mar 17, 2026
Merged

fix: add multisig_address_book source to v2 calldata local address resolution#273
fsamier merged 2 commits intomainfrom
fix/v2-multisig-address-book

Conversation

@lcastillo-ledger
Copy link
Collaborator

Summary

  • Mirrors the v0.6.0 backport (1db4a24) for the v2 calldata path: when a "local" trusted name source is specified, also include MULTISIG_ADDRESS_BOOK alongside LOCAL_ADDRESS_BOOK.
  • This was already done for the v1 path in convert/calldata/v1/field.py but was missing from the v2 path in convert/calldata/convert_erc7730_v2_input_to_calldata.py.

Test plan

  • Verify existing tests still pass
  • Verify v2 calldata generation for descriptors using "local" trusted name source now includes multisig_address_book

Made with Cursor

…solution

Mirrors the v0.6.0 backport (1db4a24) for the v2 calldata path: when a
"local" trusted name source is specified, also include
MULTISIG_ADDRESS_BOOK alongside LOCAL_ADDRESS_BOOK.

Made-with: Cursor
@lcastillo-ledger lcastillo-ledger requested a review from a team as a code owner March 16, 2026 15:25
@fsamier fsamier merged commit d35d5e8 into main Mar 17, 2026
10 checks passed
@fsamier fsamier deleted the fix/v2-multisig-address-book branch March 17, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants