chore(deps): bump library @types/node to 25 + patch hw-transport#572
Merged
Conversation
…ompat Bumps @types/node from ^24.10.0 to ^25.9.1 in the 7 published library packages, aligning them with the apps (which were already on 25). @types/node 25 made EventEmitter generic over an EventMap constraint, which exposed a latent bug in @ledgerhq/hw-transport@6.35.2: its Transport.d.ts leaks an internal `_events: EventEmitter<[never]>` field, and the bogus `[never]` tuple doesn't satisfy EventMap. Under skipLibCheck:false this fails `tsc` declaration emit for the libraries that depend on hw-transport (client, simulator). A pnpm patch retypes the field to a plain `EventEmitter`. hw-transport's only consumers here are client and simulator, and Transport.d.ts is the sole @types/node 25 incompatibility across the libs. Upstream still ships the bad line (latest stable + nightly build against @types/node 24), so the patch must be re-verified on every hw-transport bump. Stacked on #569 (zod 4 / TS 6): @types/node 25 has only been validated against TypeScript 6. devDependency + local-only patch, so no published runtime change and no changeset. Verified: build 10/10, test 26/26, typecheck 7/7, lint 10/10. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@types/nodefrom^24.10.0→^25.9.1in the 7 published library packages (core, client, client-react, server, simulator, manifest-validator, manifest-validator-cli), aligning them with the apps (docs, wallet-api-tools, client-nextjs) which were already on 25. The lockfile dedupes to a single@types/node@25.9.1.pnpm patchon@ledgerhq/hw-transport@6.35.2.Why the patch
@types/node25 madeEventEmittergeneric over anEventMapconstraint. That surfaced a latent bug in@ledgerhq/hw-transport@6.35.2: itsTransport.d.tsleaks an internal fieldand the bogus
[never]tuple doesn't satisfyEventMap. Because the libraries build withskipLibCheck: false(fromtsconfig.base.json), this failstscdeclaration emit for the packages that depend on hw-transport (client,simulator). The apps don't hit it because Next setsskipLibCheck: true— which is exactly why the libs had been pinned to@types/node24.The patch retypes the field to a plain
EventEmitter(one line):_eventsis an internal EventEmitter field that shouldn't be in the public API; nothing in our code reads it.Scope / risk
Transport.d.ts:133is the only@types/node25 incompatibility across the libs.clientandsimulator.@types/nodeis a devDependency and the patch is local-only, so there's no published runtime change (same convention as the jest 30 upgrade).Maintenance
Upstream still ships the bad line — latest stable and nightly build hw-transport against
@types/node24, so they won't notice. The patch must be re-verified on every hw-transport bump (pnpm warns if it stops applying).Verification
build 10/10 · test 26/26 · typecheck 7/7 · lint 10/10 (all forced, no cache), on top of current
main.🤖 Generated with Claude Code