Bug: Emit same object will not trigger re-render

[csr632]

live demo: https://codesandbox.io/s/rxjs-hooks-bug-zuvek?fontsize=14

Only newer version of react(with setState bail out feature) have this bug. I use 16.10.2

---

I think the bug is caused by this line:

rxjs-hooks/src/use-observable.ts

Line 54 in 203b98f

setState(value)

If my observable emit same mutable object again and again, the subscriber component will not re-render.
Because setState will bail out of updates if the next value is the same as the previous one

If the same mutable object contain different data among renders, we will not see the latest data.

[Brooooooklyn]

This behavior is by design, just the same as what React renderer behavior.

[csr632]

This is probably not a good idea. rxjs never teach its develops the idea of "immutability", and rxjs don't need the idea of "immutability".
Developer with rxjs experience is likely to get bugs(which is hard to debug) because of this.

[Brooooooklyn]

rxjs never teach its develops the idea of "immutability", and rxjs don't need the idea of "immutability".

True, but RxJS is just a tool which help you manage your data stream. You are using React as your runtime.
Every React developer should consider about Mutable or Immutable, and most of them will agree that mutate a object will not trigger rerender.

I believe if you were using Angular or VueJS you will not ask this question.