Large refactor of how message matching is done in GameChatHandler#135
Merged
omrih4 merged 1 commit intoLegitiDevs:masterfrom Apr 11, 2026
Merged
Large refactor of how message matching is done in GameChatHandler#135omrih4 merged 1 commit intoLegitiDevs:masterfrom
omrih4 merged 1 commit intoLegitiDevs:masterfrom
Conversation
Now, when a message is received, a series of MessageMatchers (there is one for each type of message that should be tracked) is iterated through, and the first one that matches is visited, calling the relevant method inside GameChatHandler to handle it. When a MessageMatcher's matches(message) is called, if it does match it takes the parts from the message that it wants which makes getting the wanted parts later much easier. There is barely any change to the actual body of code that is executed for each type.
omrih4
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a message is received, a series of MessageMatchers (there is one for each type of message that should be tracked) is iterated through, and the first one that matches is visited, calling the relevant method inside GameChatHandler to handle it.
When a MessageMatcher's matches(message) is called, if it does match it takes the parts from the message that it wants which makes getting the wanted parts later much easier.
There is barely any change to the actual body of code that is executed for each type