feat: ✨ add onLongRelease and onRepeatPress events#20
Merged
ion098 merged 8 commits intoLemLib:mainfrom Oct 25, 2024
Merged
Conversation
ion098
reviewed
Oct 5, 2024
Collaborator
ion098
left a comment
ion098
left a comment
There was a problem hiding this comment.
The logic looks good, please run clang-format on this
Co-authored-by: ion098 <146852218+ion098@users.noreply.github.com>
Co-authored-by: ion098 <146852218+ion098@users.noreply.github.com>
Co-authored-by: ion098 <146852218+ion098@users.noreply.github.com>
Co-authored-by: ion098 <146852218+ion098@users.noreply.github.com>
SizzinSeal
reviewed
Oct 25, 2024
|
|
||
| void aPress1() { | ||
| last_repeat_press_time = pros::millis(); | ||
| printf("A Pressed!\n"); |
SizzinSeal
approved these changes
Oct 25, 2024
Member
SizzinSeal
left a comment
SizzinSeal
left a comment
There was a problem hiding this comment.
LGTM, just one comment on the example in src/main.cpp but its a tiny nitpick
ion098
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue #17