Skip to content

Feature/#149 a11y add role log #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brauliodiez merged 3 commits into from
Apr 22, 2022
Merged

Feature/#149 a11y add role log #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d27ac46
add role on student
nasdan Apr 20, 2022
2a88afc
add role on trainer
nasdan Apr 20, 2022
0983d29
fix specs
nasdan Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions front/src/pods/student/student.component.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('StudentComponent tests', () => {

// Assert
const sessionName = screen.getByRole('heading');
const textArea = screen.getByRole('textbox');
const textArea = screen.getByRole('log');

expect(sessionName).toHaveTextContent(expectedSessionNameText);
expect(textArea).toHaveValue(props.log);
Expand Down Expand Up @@ -69,7 +69,7 @@ describe('StudentComponent tests', () => {
render(<StudentComponent {...props} />);

// Assert
const textArea = screen.getByRole('textbox');
const textArea = screen.getByRole('log');
expect(textArea).toHaveTextContent('');
});

Expand All @@ -84,7 +84,7 @@ describe('StudentComponent tests', () => {
render(<StudentComponent {...props} />);

// Assert
const textArea = screen.getByRole('textbox');
const textArea = screen.getByRole('log');
expect(textArea).toHaveTextContent('');
});
});
16 changes: 13 additions & 3 deletions front/src/pods/student/student.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,39 @@ interface Props {
export const StudentComponent: React.FC<Props> = props => {
const { room, log } = props;

const {isAutoScrollEnabled, setIsAutoScrollEnabled, textAreaRef, doAutoScroll} = useAutoScroll();
const {
isAutoScrollEnabled,
setIsAutoScrollEnabled,
textAreaRef,
doAutoScroll,
} = useAutoScroll();

React.useEffect(() => {
doAutoScroll();
}, [log]);

return (

<>
<main className={innerClasses.root}>
<Typography className={innerClasses.sessionName} variant="body1" role="heading">
<Typography
className={innerClasses.sessionName}
variant="body1"
role="heading"
>
Session name: {room ?? ''}
</Typography>
<label className={innerClasses.label} htmlFor="session">
Content
</label>
<TextareaAutosize
role="log"
ref={textAreaRef}
id="session"
rowsMax={30}
rowsMin={30}
className={innerClasses.textarea}
value={log ?? ''}
readOnly={true}
/>
<FormControlLabel
label="Disable AutoScroll"
Expand Down
6 changes: 3 additions & 3 deletions front/src/pods/trainer/components/session.component.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('SessionComponent unit tests', () => {

render(<SessionComponent {...props} />);

const textArea = screen.getByRole('textbox');
const textArea = screen.getByRole('log');
const sendFullContentButton = screen.getAllByRole('button')[1];

userEvent.type(textArea, 'How are you doing?');
Expand All @@ -40,7 +40,7 @@ describe('SessionComponent unit tests', () => {

render(<SessionComponent {...props} />);

const textArea = screen.getByRole('textbox');
const textArea = screen.getByRole('log');
const sendFullContentButton = screen.getAllByRole('button')[1];

userEvent.type(textArea, 'How are you doing?');
Expand All @@ -64,7 +64,7 @@ describe('SessionComponent unit tests', () => {

render(<SessionComponent {...props} />);

const textArea = screen.getByRole('textbox');
const textArea = screen.getByRole('log');
const undoButton = screen.getAllByRole('button')[0];

userEvent.type(textArea, 'How are you doing?');
Expand Down
1 change: 1 addition & 0 deletions front/src/pods/trainer/components/session.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const SessionComponent: React.FC<Props> = props => {
</label>

<TextareaAutosize
role="log"
ref={textAreaRef}
id="session"
rowsMax={20}
Expand Down