Skip to content

#66 change readme#67

Merged
brauliodiez merged 3 commits intomasterfrom
#66-change-readme
Mar 29, 2017
Merged

#66 change readme#67
brauliodiez merged 3 commits intomasterfrom
#66-change-readme

Conversation

@crsanti
Copy link
Copy Markdown
Member

@crsanti crsanti commented Mar 29, 2017

This fixed #66 .

@crsanti crsanti self-assigned this Mar 29, 2017
@crsanti crsanti requested review from brauliodiez and nasdan March 29, 2017 16:33
@brauliodiez
Copy link
Copy Markdown
Member

Good stuff, almost there !!! Just only pending the ES6 sample and we are good to go.

Could you create an entry in the github io page giving tips on how to implement a multilanguage approac (just based on the TYPE field), this can server as an entry point for @luisgonzalo to implement the sample

@brauliodiez brauliodiez merged commit 766d190 into master Mar 29, 2017
@crsanti
Copy link
Copy Markdown
Member Author

crsanti commented Mar 29, 2017

Do you mean by using a service (that gets the message from a resource) and pass the type to get the error message??

@brauliodiez
Copy link
Copy Markdown
Member

Just guidance, in the github io just add one section / subsection where we talk about multinlanguage support, providing some guidance about how to impement it in an app (but just create the issue), let's focus on closing the 1.0 version

@crsanti
Copy link
Copy Markdown
Member Author

crsanti commented Mar 29, 2017

ok!

Comment thread README.md
# FormBaseValidation + Sample Form #
### Trigger certain validations in each constraint:

Add `eventsFilter` with on or more events:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo with one or more?

Copy link
Copy Markdown
Member Author

@crsanti crsanti Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there is my boy 👏

@crsanti crsanti deleted the #66-change-readme branch March 30, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change README.md with basic info and link to github.io page.

3 participants