Skip to content

Pending feedback from#58#71

Merged
crsanti merged 6 commits intomasterfrom
#58-fix-pending-changes
Mar 30, 2017
Merged

Pending feedback from#58#71
crsanti merged 6 commits intomasterfrom
#58-fix-pending-changes

Conversation

@crsanti
Copy link
Copy Markdown
Member

@crsanti crsanti commented Mar 29, 2017 •
edited
Loading

Solves #58.

@crsanti crsanti self-assigned this Mar 29, 2017
@crsanti crsanti requested review from brauliodiez and nasdan March 29, 2017 18:56
@crsanti crsanti changed the title Fixes for #65 Affix lib dependencies Mar 30, 2017
@crsanti crsanti changed the title Affix lib dependencies Fix pending feedback from#58 Mar 30, 2017
@crsanti crsanti changed the title Fix pending feedback from#58 Pending feedback from#58 Mar 30, 2017
@nasdan
Copy link
Copy Markdown
Member

nasdan commented Mar 30, 2017

  • Rename OnChange eventsFilter to onChange
  • In fieldValidationEventFilter.spec use annotation result[0].eventsFilter["OnChange"] to avoid TypeScript errors

@crsanti
Changed constant OnChange to onChange.
902d8ca 
Changed some tests where accessing properties would not give intelisense (with atom-typescript it causes error).
Fixed typo.
@crsanti crsanti merged commit 8e95996 into master Mar 30, 2017
@crsanti crsanti deleted the #58-fix-pending-changes branch March 30, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nasdan nasdan nasdan approved these changes

@brauliodiez brauliodiez Awaiting requested review from brauliodiez

Assignees

@crsanti crsanti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crsanti @nasdan