Refactor/vscode-extension-mcp-restructure#834
Merged
nasdan merged 4 commits intofeature/#812-implement-vscode-ext-and-mcpfrom May 8, 2026
Merged
Conversation
nasdan
reviewed
May 8, 2026
| export * from './server-definition-provider'; | ||
| export * from './document-bridge'; | ||
| export * from './external-clients'; | ||
| export * from './setup'; |
Member
There was a problem hiding this comment.
I think we only need to export the setup file, isn't it??
nasdan
reviewed
May 8, 2026
|
|
||
| context.subscriptions.push({ | ||
| dispose: () => { | ||
| server.close(); |
Member
There was a problem hiding this comment.
server.close() stops accepting new connections but does not close existing ones, so any in-flight request at deactivation time is left hanging briefly.
If the Node version allows it (18.2+), consider adding server.closeAllConnections() before server.close():
dispose: () => {
server.closeAllConnections?.();
server.close();
try { unlinkSync(portFile); } catch {}
},
Collaborator
Author
There was a problem hiding this comment.
Fixed. The minimum Node.js version for the minimum supported VS Code version is 22, so closeAllConnections is safe to use.
nasdan
merged commit 7d14768
into
feature/#812-implement-vscode-ext-and-mcp
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.