Skip to content

fix: add non-empty-string inference for call site in MessageName #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ben Challis (ben-challis) merged 1 commit into from
May 28, 2024
Merged

fix: add non-empty-string inference for call site in MessageName #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/MessageName.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,23 @@
final readonly class MessageName
{
/**
* @var non-empty-string
* @param non-empty-string $name
*/
private string $name;
private function __construct(private string $name) {}

/**
* @throws InvalidMessageName If the message name is empty.
*
* @phpstan-assert non-empty-string $name
*/
private function __construct(string $name)
public static function fromString(string $name): self
{
if (\trim($name) === '') {
throw InvalidMessageName::empty();
}

/** @var non-empty-string $name */
$this->name = $name;
}

/**
* @throws InvalidMessageName If the message name is empty.
*/
public static function fromString(string $name): self
{
return new self($name);
}

Expand Down