[github-workflows-kt] Add alias for host name for Jaeger#21
Merged
LeoColman merged 1 commit intoLeoColman:mainfrom Nov 25, 2024
Merged
[github-workflows-kt] Add alias for host name for Jaeger#21LeoColman merged 1 commit intoLeoColman:mainfrom
LeoColman merged 1 commit intoLeoColman:mainfrom
Conversation
krzema12
changed the title
LeoColman
reviewed
Nov 24, 2024
| reverse_proxy: | ||
| # An abstract host name, used by the application. Allows abstracting | ||
| # out what component is the receiver of traces. | ||
| aliases: [traces_collector] |
Owner
There was a problem hiding this comment.
No idea how this is supposed to work with reverse_proxy.
If this does what I think it does, 'http://trace_collector:16686' should work inside other containers.
By default only 'http://jaeger:16686' would be published.
Is this what we want to change?
Owner
There was a problem hiding this comment.
which seems to be exactly what your example is doing in the end
Contributor
Author
There was a problem hiding this comment.
Yes, that's exactly the goal :) Basically an alias for jaeger.
krzema12
added a commit
to typesafegithub/github-workflows-kt
that referenced
this pull request
Nov 25, 2024
We're about to change a service which receives the traces. It's now Jaeger, and thanks to this change: LeoColman/MyStack#21, Jaeger is now reachable by the more abstract host name. It lets us abstract out what component receives the traces by simply configuring in Docker Compose's config which service will be available under this hostname. Ultimately, it will allow us to enable aggregated metrics with OTel Collector and Prometheus without downtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step to be able to add support for viewing aggregated metrics in Jaeger. Following the guide here: https://github.com/jaegertracing/jaeger/tree/main/docker-compose/monitor, we need to switch the traces collector, from Jaeger to OTel Collector. To be able to do it without downtime, we need to do it in three steps:
This change is inspired by https://github.com/jaegertracing/jaeger/blob/4d1c7d8ddc23e5492772b3f985205dd423fbd363/docker-compose/monitor/docker-compose.yml#L23