Merged
Conversation
- new best-of-breed mocking that combines what was being done in the SDK, in the Rithum layers, and in copy/paste code - written in Typescript - fully-tested - markdown doc for coding-assist agents to be able to use it
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
czirker
approved these changes
Mar 14, 2026
bxgrant
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Adds a substantial new mocking layer that overrides core SDK queue read/write, enrich/offload, checkpointing, and S3 stream behavior; while isolated to tests, inaccuracies vs real pipeline semantics could lead to false confidence in unit tests.
Overview
Introduces a new
lib/mock-sdk.tsutility that wraps anRStreamsSdkinstance with a.mockcontrol surface for unit tests, intercepting queue reads/writes (fromLeo/toLeo/load), checkpointing, cron/bot calls, and optional S3 stream interactions while preserving real stream utilities.Adds extensive unit + integration coverage (
test/lib.mock-sdk.utest.ts) validating end-to-endenrich/offloadbehavior, spy/capture APIs, reset semantics, and S3 mocking, plus a newlib/mock-sdk.mdguide documenting recommended handler-testing patterns and the mock API.Updates
.gitignoreto exclude local Claude settings (.claude/settings.local.json).Written by Cursor Bugbot for commit 7802bd7. This will update automatically on new commits. Configure here.