fix(terminal): inline WS auth — Header/Query deps don't inject on WS#27
Merged
Leolebleis merged 1 commit intomainfrom May 3, 2026
Merged
fix(terminal): inline WS auth — Header/Query deps don't inject on WS#27Leolebleis merged 1 commit intomainfrom
Leolebleis merged 1 commit intomainfrom
Conversation
FastAPI's WebSocket dependency resolver doesn't inject Header() or Query() parameters into shared deps the way HTTP does, so `require_api_key` raised 403 on every WS connection — the credential never reached the dep, even when set in either the X-API-Key header or ?api_key= query. Read directly from the WS scope instead. The HTTP routes still go through the shared dep unchanged. Also drops require_api_key from the terminal_router include — auth is now the WS handler's responsibility for this router.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brew terminal WS endpoint kept 403'ing despite both `X-API-Key` header and `?api_key=` query being set correctly. Root cause: FastAPI's WebSocket dependency resolver doesn't inject `Header()` or `Query()` into shared deps the same way HTTP does, so the credential never reached `require_api_key` and it always saw both keys as `None`.
Read the credential directly from the WS scope inside the WS handler. HTTP routes are unchanged.
Test plan