Skip to content

chore(ci): standardize runner to blacksmith-4vcpu-ubuntu-2404#128

Merged
bedatty merged 2 commits intodevelopfrom
chore/standardize-blacksmith-runner
Mar 10, 2026
Merged

chore(ci): standardize runner to blacksmith-4vcpu-ubuntu-2404#128
bedatty merged 2 commits intodevelopfrom
chore/standardize-blacksmith-runner

Conversation

@bedatty
Copy link
Contributor

@bedatty bedatty commented Mar 10, 2026

Lerian

GitHub Actions Shared Workflows


Description

Standardize all remaining ubuntu-latest runner references to blacksmith-4vcpu-ubuntu-2404 across workflows and add the runner requirement to the Claude command rules (gha.md, workflow.md, composite.md).

Workflows updated:

  • branch-cleanup.yml — job cleanup
  • gptchangelog.yml — job notify_sync_pr
  • labels-sync.yml — job sync
  • dispatch-helm.ymlrunner_type input default
  • helm-update-chart.ymlrunner_type input default

Rules updated:

  • .claude/commands/gha.md — added Runner section
  • .claude/commands/workflow.md — added Runner section
  • .claude/commands/composite.md — added Runner section for usage examples

Type of Change

  • chore: Dependency bumps, config updates, maintenance

Breaking Changes

None. Callers that explicitly pass a runner_type input are unaffected. Only the default value changes for dispatch-helm.yml and helm-update-chart.yml.

Testing

  • YAML syntax validated locally
  • Verified all existing inputs still work with default values
  • Checked that unrelated workflows are not affected

Related Issues

N/A

Summary by CodeRabbit

  • Documentation

    • Added Runner guidance across composite, workflow, and reusable-workflow docs: examples now require a specific standard runner and explicitly list disallowed alternatives.
  • Chores

    • Updated GitHub Actions workflows and defaults to use a single, consistent runner environment across multiple workflows.

Replace ubuntu-latest with blacksmith-4vcpu-ubuntu-2404 across
remaining workflows and add runner requirement to command rules.
@bedatty bedatty requested a review from a team as a code owner March 10, 2026 13:20
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8dfdb2a2-07de-449c-8ca7-83a0b6efd031

📥 Commits

Reviewing files that changed from the base of the PR and between 91c8cd3 and 13e7761.

📒 Files selected for processing (2)
  • .cursor/rules/composite-actions.mdc
  • .cursor/rules/reusable-workflows.mdc

Walkthrough

The PR adds documentation guidance and updates GitHub Actions runner settings to require the blacksmith-4vcpu-ubuntu-2404 runner for composites, reusable workflows, and specified workflow jobs, replacing prior ubuntu-latest defaults and explicitly disallowing several other runners.

Changes

Cohort / File(s) Summary
Documentation — composite / gha / workflow
\.claude/commands/composite.md, \.claude/commands/gha.md, \.claude/commands/workflow.md
Inserted new "Runner" sections requiring blacksmith-4vcpu-ubuntu-2404 in examples and documenting prohibited runners (ubuntu-latest, ubuntu-22.04, self-hosted).
Documentation — cursor rules
\.cursor/rules/composite-actions.mdc, \.cursor/rules/reusable-workflows.mdc
Added runner guidance to rules docs specifying blacksmith-4vcpu-ubuntu-2404 and negative examples for disallowed runners.
Workflows — runner changes
\.github/workflows/branch-cleanup.yml, \.github/workflows/dispatch-helm.yml, \.github/workflows/gptchangelog.yml, \.github/workflows/helm-update-chart.yml, \.github/workflows/labels-sync.yml
Replaced runner specification or default input value from ubuntu-latest to blacksmith-4vcpu-ubuntu-2404 in five workflow files (no other step logic changed).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: standardizing CI runner configuration to a specific image across workflows and documentation.
Description check ✅ Passed The description covers all required template sections: clear summary, correct type-of-change checkbox, breaking-changes confirmation, and testing validation with specific items checked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/standardize-blacksmith-runner

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/gptchangelog.yml:
- Line 723: The job's runs-on value is hard-coded to
"blacksmith-4vcpu-ubuntu-2404" but the workflow defines an inputs.runner_type
default of "blacksmith" and other jobs use ${{ inputs.runner_type }}; fix by
either (A) replacing the literal runs-on value with ${{ inputs.runner_type }} so
the job uses the shared input, or (B) updating the workflow input named
runner_type (the inputs.runner_type default) to "blacksmith-4vcpu-ubuntu-2404"
so the default matches this job; adjust either the runs-on entry or the
inputs.runner_type default accordingly to restore consistency.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b0fdbf84-9966-4b1f-81b6-86b249dce03b

📥 Commits

Reviewing files that changed from the base of the PR and between 605f2d0 and 91c8cd3.

📒 Files selected for processing (8)
  • .claude/commands/composite.md
  • .claude/commands/gha.md
  • .claude/commands/workflow.md
  • .github/workflows/branch-cleanup.yml
  • .github/workflows/dispatch-helm.yml
  • .github/workflows/gptchangelog.yml
  • .github/workflows/helm-update-chart.yml
  • .github/workflows/labels-sync.yml

@bedatty bedatty self-assigned this Mar 10, 2026
@bedatty bedatty merged commit f4f4f69 into develop Mar 10, 2026
1 check passed
@github-actions github-actions bot deleted the chore/standardize-blacksmith-runner branch March 10, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant