chore(ci): standardize runner to blacksmith-4vcpu-ubuntu-2404#128
chore(ci): standardize runner to blacksmith-4vcpu-ubuntu-2404#128
Conversation
Replace ubuntu-latest with blacksmith-4vcpu-ubuntu-2404 across remaining workflows and add runner requirement to command rules.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR adds documentation guidance and updates GitHub Actions runner settings to require the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gptchangelog.yml:
- Line 723: The job's runs-on value is hard-coded to
"blacksmith-4vcpu-ubuntu-2404" but the workflow defines an inputs.runner_type
default of "blacksmith" and other jobs use ${{ inputs.runner_type }}; fix by
either (A) replacing the literal runs-on value with ${{ inputs.runner_type }} so
the job uses the shared input, or (B) updating the workflow input named
runner_type (the inputs.runner_type default) to "blacksmith-4vcpu-ubuntu-2404"
so the default matches this job; adjust either the runs-on entry or the
inputs.runner_type default accordingly to restore consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b0fdbf84-9966-4b1f-81b6-86b249dce03b
📒 Files selected for processing (8)
.claude/commands/composite.md.claude/commands/gha.md.claude/commands/workflow.md.github/workflows/branch-cleanup.yml.github/workflows/dispatch-helm.yml.github/workflows/gptchangelog.yml.github/workflows/helm-update-chart.yml.github/workflows/labels-sync.yml
GitHub Actions Shared Workflows
Description
Standardize all remaining
ubuntu-latestrunner references toblacksmith-4vcpu-ubuntu-2404across workflows and add the runner requirement to the Claude command rules (gha.md,workflow.md,composite.md).Workflows updated:
branch-cleanup.yml— jobcleanupgptchangelog.yml— jobnotify_sync_prlabels-sync.yml— jobsyncdispatch-helm.yml—runner_typeinput defaulthelm-update-chart.yml—runner_typeinput defaultRules updated:
.claude/commands/gha.md— added Runner section.claude/commands/workflow.md— added Runner section.claude/commands/composite.md— added Runner section for usage examplesType of Change
chore: Dependency bumps, config updates, maintenanceBreaking Changes
None. Callers that explicitly pass a
runner_typeinput are unaffected. Only the default value changes fordispatch-helm.ymlandhelm-update-chart.yml.Testing
Related Issues
N/A
Summary by CodeRabbit
Documentation
Chores