Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughFour documentation files updated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Lint Analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions Shared Workflows
Description
Fixes cosign verification regex in documentation to support both branch and tag-triggered workflows.
The previous regex
@refs/heads/.*only matched branch-triggered workflow certificates. Since builds are triggered by tag pushes (on: push: tags), the cosign keyless signing embedsrefs/tags/<tag>in the certificate identity, causing verification to fail with the documented command.Updated to
@refs/(heads|tags)/.+across all 4 doc files:docs/build-workflow.mddocs/go-release-workflow.mddocs/typescript-build.mdsrc/security/cosign-sign/README.mdAlso escaped the
.ingithub.comtogithub\.comfor regex correctness.Type of Change
docs: Documentation only (README, docs/, inline comments)Breaking Changes
None.
Testing
refs/heads/mainandrefs/tags/v1.0.0patternsRelated Issues
Related to #203
Summary by CodeRabbit
Documentation