Skip to content

feat(deployment-matrix): register plugin-br-pix-switch for firmino#369

Merged
ferr3ira-gabriel merged 1 commit into
developfrom
feat/register-plugin-br-pix-switch-in-deployment-matrix
May 14, 2026
Merged

feat(deployment-matrix): register plugin-br-pix-switch for firmino#369
ferr3ira-gabriel merged 1 commit into
developfrom
feat/register-plugin-br-pix-switch-in-deployment-matrix

Conversation

@ferr3ira-gabriel
Copy link
Copy Markdown
Member

@ferr3ira-gabriel ferr3ira-gabriel commented May 14, 2026

Summary

Registers plugin-br-pix-switch in the deployment matrix so the gitops-update.yml reusable workflow recognizes it as a valid app and auto-updates midaz-firmino-gitops when its build pipeline publishes new beta tags.

Changes

  • config/deployment-matrix.yml:
    • Add plugin-br-pix-switch to apps.registry (with a comment noting it's the multi-component PIX hub).
    • Add plugin-br-pix-switch to clusters.firmino.apps (the only cluster where it's deployed today).

Validation

src/lint/deployment-matrix validator passes locally with the change: Deployment matrix is valid (21 apps registered, 4 clusters defined).

Followup

After this merges, a sibling PR in LerianStudio/plugin-br-pix-switch will add the update_gitops job to its build.yml, completing the auto-flow. The 10 per-component build artifacts (gitops-tags-plugin-br-pix-switch-spi-api.tag, etc.) will be consumed by gitops-update.yml and mapped to the matching image.tag keys in the firmino-dev values.yaml.

If/when plugin-br-pix-switch rolls out to other clusters (clotilde / anacleto / benedita), append it to the corresponding apps: lists. No code changes needed.

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration to allow the plugin "plugin-br-pix-switch" and enable its automated deployment to the firmino cluster, ensuring it can be rolled out via existing deployment pipelines.
    • Maintains existing deployment rules and add-on rollout behavior for other apps.

Review Change Stack

Review Change Stack

@ferr3ira-gabriel ferr3ira-gabriel requested a review from a team as a code owner May 14, 2026 17:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ac356259-2657-4746-a622-8cdf830eadfe

📥 Commits

Reviewing files that changed from the base of the PR and between 81b4b91 and e1f6f71.

📒 Files selected for processing (1)
  • config/deployment-matrix.yml

Walkthrough

The deployment matrix adds plugin-br-pix-switch to the global apps.registry allowlist and to clusters.firmino.apps, enabling its deployment to the firmino Kubernetes cluster.

Changes

Plugin Deployment Configuration

Layer / File(s) Summary
Plugin deployment registry and cluster assignment
config/deployment-matrix.yml
plugin-br-pix-switch is added to the global apps.registry allowlist (line 50) and to the firmino cluster's apps list (line 79).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: registering a new application in the deployment matrix for a specific cluster.
Description check ✅ Passed The description covers the main objective, specific file changes, validation results, and follow-up steps, though it diverges from the repository's template structure designed for workflow changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/register-plugin-br-pix-switch-in-deployment-matrix

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 14, 2026

⚠️ Invalid Source Branch

Pull requests to main can only come from:

  • develop
  • hotfix/*

Your source branch: feat/register-plugin-br-pix-switch-in-deployment-matrix

Please change the base branch or create a PR from an allowed branch.

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 14, 2026

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 14, 2026

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 1 file(s) ✅ success
Action Lint no changes ⏭️ skipped
Pinned Actions no changes ⏭️ skipped
Markdown Link Check no changes ⏭️ skipped
Spelling Check 1 file(s) ✅ success
Shell Check no changes ⏭️ skipped
README Check no changes ⏭️ skipped
Composite Schema no changes ⏭️ skipped
Deployment Matrix 1 file(s) ✅ success

🔍 View full scan logs

Adds plugin-br-pix-switch to the apps.registry and clusters.firmino.apps
list so the gitops-update workflow can auto-update midaz-firmino-gitops
when the source repo publishes new beta tags.

Only firmino for now. Adding to other clusters (clotilde, anacleto,
benedita) is a follow-up once the multi-component plugin is rolled out
there.
@ferr3ira-gabriel ferr3ira-gabriel force-pushed the feat/register-plugin-br-pix-switch-in-deployment-matrix branch from 81b4b91 to e1f6f71 Compare May 14, 2026 17:22
@ferr3ira-gabriel ferr3ira-gabriel changed the base branch from main to develop May 14, 2026 17:22
@lerian-studio lerian-studio added size/XS PR changes < 50 lines deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) labels May 14, 2026
@ferr3ira-gabriel ferr3ira-gabriel merged commit 0aaa506 into develop May 14, 2026
34 of 35 checks passed
@github-actions github-actions Bot deleted the feat/register-plugin-br-pix-switch-in-deployment-matrix branch May 14, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) size/XS PR changes < 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants