Skip to content

feat(deployment-matrix): register severino-bot for benedita#374

Merged
ferr3ira-gabriel merged 1 commit into
developfrom
feat/register-severino-bot-in-deployment-matrix
May 15, 2026
Merged

feat(deployment-matrix): register severino-bot for benedita#374
ferr3ira-gabriel merged 1 commit into
developfrom
feat/register-severino-bot-in-deployment-matrix

Conversation

@ferr3ira-gabriel
Copy link
Copy Markdown
Member

@ferr3ira-gabriel ferr3ira-gabriel commented May 15, 2026

What

Registers severino-bot in the deployment matrix so the shared gitops-update.yml workflow can resolve the target cluster (benedita) at runtime when severino-bot release tags are cut.

Changes

  • apps.registry: add severino-bot under a new Benedita-exclusive section (mirrors the existing Anacleto-exclusive grouping for ungoliant-controller)
  • clusters.benedita.apps: add severino-bot to the resolved list

Why

severino-bot was just moved from firmino → benedita in midaz-firmino-gitops (see midaz-firmino-gitops #683, merged). A follow-up PR on LerianStudio/severino-bot introduces a shared-workflow-based build pipeline with an update_gitops job that auto-bumps the image tag in environments/benedita/kustomize/severino/kustomization.yaml. That job calls gitops-update.yml, which resolves clusters from this matrix — so severino-bot must be registered here first.

Order of operations

  1. This PR merges → matrix on main includes severino-bot
  2. severino-bot PR (still in review) merges → build.yml uses shared workflow + update_gitops
  3. Next severino-bot release tag → build → update_gitops resolves benedita from the matrix → commits image-tag bump to midaz-firmino-gitops → ArgoCD syncs

Risk

Zero runtime risk. This file is in self-release.yml's paths-ignore — matrix-only changes don't cut a tag. Callers resolve from main at runtime, so the change takes effect immediately on merge without bumping the shared-workflows version.

Summary by CodeRabbit

  • Chores
    • Enabled deployment of the severino-bot application to production infrastructure, making it available for cluster operations.

Review Change Stack

severino-bot is moving from firmino (kustomize/severino) to benedita
in midaz-firmino-gitops. This registers the app so the upcoming
build.yml -> update_gitops job can resolve the target cluster at
runtime when severino-bot release tags are cut.

- apps.registry: add severino-bot under a new 'Benedita-exclusive'
  section (mirrors the existing 'Anacleto-exclusive' grouping)
- clusters.benedita.apps: add severino-bot to the resolved list
@ferr3ira-gabriel ferr3ira-gabriel requested a review from a team as a code owner May 15, 2026 19:43
@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 15, 2026

⚠️ Invalid Source Branch

Pull requests to main can only come from:

  • develop
  • hotfix/*

Your source branch: feat/register-severino-bot-in-deployment-matrix

Please change the base branch or create a PR from an allowed branch.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 74c9df5e-91ae-433b-a349-81dac2d41253

📥 Commits

Reviewing files that changed from the base of the PR and between ddf45f5 and 1d9db5a.

📒 Files selected for processing (1)
  • config/deployment-matrix.yml

Walkthrough

This PR adds severino-bot as a deployable app to the benedita cluster by registering it in the global apps allowlist and assigning it to that cluster's deployment scope within config/deployment-matrix.yml.

Changes

Deploy severino-bot to benedita cluster

Layer / File(s) Summary
Register severino-bot for benedita deployment
config/deployment-matrix.yml
severino-bot is added to apps.registry (lines 66–68) and to clusters.benedita.apps (line 144), enabling it as a deployable application for the benedita cluster.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/XS, deployment-matrix

Suggested reviewers

  • bedatty
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: registering severino-bot in the deployment matrix for the benedita cluster.
Description check ✅ Passed The description provides clear context on what changes, why they're needed, the order of operations, and explicitly states zero runtime risk. All critical information is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/register-severino-bot-in-deployment-matrix

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 15, 2026

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 15, 2026

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 1 file(s) ✅ success
Action Lint no changes ⏭️ skipped
Pinned Actions no changes ⏭️ skipped
Markdown Link Check no changes ⏭️ skipped
Spelling Check 1 file(s) ✅ success
Shell Check no changes ⏭️ skipped
README Check no changes ⏭️ skipped
Composite Schema no changes ⏭️ skipped
Deployment Matrix 1 file(s) ✅ success

🔍 View full scan logs

@ferr3ira-gabriel ferr3ira-gabriel changed the base branch from main to develop May 15, 2026 19:45
@lerian-studio lerian-studio added size/XS PR changes < 50 lines deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) labels May 15, 2026
@ferr3ira-gabriel ferr3ira-gabriel merged commit 66b3fa7 into develop May 15, 2026
50 of 52 checks passed
@github-actions github-actions Bot deleted the feat/register-severino-bot-in-deployment-matrix branch May 15, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) size/XS PR changes < 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants