Skip to content

fix(release): develop to main#383

Merged
bedatty merged 3 commits into
mainfrom
develop
May 28, 2026
Merged

fix(release): develop to main#383
bedatty merged 3 commits into
mainfrom
develop

Conversation

@bedatty
Copy link
Copy Markdown
Contributor

@bedatty bedatty commented May 28, 2026

Lerian

GitHub Actions Shared Workflows


Description

Type of Change

  • feat: New workflow or new input/output/step in an existing workflow
  • fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)
  • perf: Performance improvement (e.g. caching, parallelism, reduced steps)
  • refactor: Internal restructuring with no behavior change
  • docs: Documentation only (README, docs/, inline comments)
  • ci: Changes to self-CI (workflows under .github/workflows/ that run on this repo)
  • chore: Dependency bumps, config updates, maintenance
  • test: Adding or updating tests
  • BREAKING CHANGE: Callers must update their configuration after this PR

Breaking Changes

None.

Testing

  • YAML syntax validated locally
  • Triggered a real workflow run on a caller repository using @this-branch or the beta tag
  • Verified all existing inputs still work with default values
  • Confirmed no secrets or tokens are printed in logs
  • Checked that unrelated workflows are not affected

Caller repo / workflow run:

Related Issues

Closes #

Summary by CodeRabbit

  • Chores
    • Updated GitHub workflow action dependencies to use newer versions of the GitHub App token generation action across multiple workflows.
    • Updated service deployment configuration to enable broader availability across additional deployment clusters.

Review Change Stack

dependabot Bot and others added 3 commits May 18, 2026 20:27
Bumps the release group with 1 update: [actions/create-github-app-token](https://github.com/actions/create-github-app-token).


Updates `actions/create-github-app-token` from 3.1.1 to 3.2.0
- [Release notes](https://github.com/actions/create-github-app-token/releases)
- [Changelog](https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md)
- [Commits](actions/create-github-app-token@1b10c78...bcd2ba4)

---
updated-dependencies:
- dependency-name: actions/create-github-app-token
  dependency-version: 3.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: release
...

Signed-off-by: dependabot[bot] <support@github.com>
…evelop/release-9f1c31c749

chore(deps): bump actions/create-github-app-token from 3.1.1 to 3.2.0 in the release group
…notifications

chore(deployment-matrix): update matrix lerian notifications
@bedatty bedatty requested a review from a team as a code owner May 28, 2026 16:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Walkthrough

This PR contains two independent updates: a pinned dependency bump of actions/create-github-app-token from v3.1.1 to v3.2.0 across seven workflows, and registration of lerian-notification in the deployment matrix for three clusters with removal of the prior development-only qualifier.

Changes

GitHub App Token Action Update

Layer / File(s) Summary
Update actions/create-github-app-token to v3.2.0
.github/workflows/backmerge.yml, gptchangelog.yml, helm-update-chart.yml, helm-upgrade-doc.yml, release-notification.yml, release.yml, typescript-release.yml
Pinned commit SHA for actions/create-github-app-token bumped from v3.1.1 to v3.2.0 in all token generation steps without altering step inputs or workflow logic.

Deployment Matrix Configuration

Layer / File(s) Summary
Register lerian-notification in deployment matrix
config/deployment-matrix.yml
lerian-notification is added to global apps.registry (removing prior "firmino-dev only today" note) and mapped to clotilde, anacleto, and benedita clusters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

workflow, dependencies, deployment-matrix, size/XS

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning Description is incomplete; the 'Description' section summarizing what the PR does and which workflows are affected is empty, and no caller repo/workflow run link is provided despite testing being marked complete. Fill in the Description section explaining the action version bump across six workflows and the deployment-matrix.yml changes. Add the caller repo/workflow run link to validate the testing claim.
Title check ❓ Inconclusive Title is vague and does not describe the actual changes; 'develop to main' suggests a merge operation rather than the dependency bumps and config updates present in the changeset. Use a more descriptive title reflecting the primary changes, such as 'chore: bump actions/create-github-app-token to v3.2.0 and update deployment matrix' or 'chore(deps): update GitHub App token action and deployment config'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio lerian-studio added size/XS PR changes < 50 lines workflow Changes to one or more reusable workflow files typescript Changes to TypeScript or Frontend workflows notify Changes to notification composite actions (src/notify/) deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) changelog Changes to changelog generation composite actions (src/changelog/) labels May 28, 2026
@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 28, 2026

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 28, 2026

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 8 file(s) ✅ success
Action Lint 7 file(s) ✅ success
Pinned Actions 7 file(s) ✅ success
Markdown Link Check no changes ⏭️ skipped
Spelling Check 8 file(s) ✅ success
Shell Check 7 file(s) ✅ success
README Check 7 file(s) ✅ success
Composite Schema no changes ⏭️ skipped
Deployment Matrix 1 file(s) ✅ success
⚠️ Warnings (3)

Pinned Actions

.github

  • .github (line 107) — Found 2 internal action(s) not pinned to a version. Consider pinning to vX.Y.Z.

.github/workflows/release-notification.yml

  • .github/workflows/release-notification.yml (line 180) — Internal composite must use floating major tag (e.g. @v1) or develop/main for testing: uses: LerianStudio/github-actions-shared-workflows/src/notify/slack-release@v1.18.0
  • .github/workflows/release-notification.yml (line 168) — Internal composite must use floating major tag (e.g. @v1) or develop/main for testing: uses: LerianStudio/github-actions-shared-workflows/src/notify/discord-release@v1.18.0

🔍 View full scan logs

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 28, 2026

🛡️ CodeQL Analysis Results

Languages analyzed: actions

✅ No security issues found.


🔍 View full scan logs | 🛡️ Security tab

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/backmerge.yml (1)

145-149: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Scope GitHub App token permissions to least privilege in .github/workflows/backmerge.yml
actions/create-github-app-token with no permission-* inputs will issue a token inheriting all permissions granted to the GitHub App installation; set explicit permission-* values (and keep repositories/owner explicit if desired) to match only what the backmerge job needs, and apply the same least-privilege scoping to any other workflows that create the same kind of token in this PR.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/backmerge.yml around lines 145 - 149, The workflow
currently creates a GitHub App token via the actions/create-github-app-token
step with id "app-token" but does not declare any permission-* inputs, so the
token inherits all installation permissions; update the "app-token" step to add
explicit permission-* inputs (e.g., permission-contents,
permission-pull-requests, permission-issues, etc.) that exactly match what the
backmerge job needs and set repositories/owner inputs if applicable to restrict
scope, ensuring you choose the least-privilege set for this job and replicate
the same scoping in any other workflow steps that create the same token.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/deployment-matrix.yml`:
- Line 109: The deployment matrix has inconsistent ordering for the service name
lerian-notification across clusters; to fix it, open the
config/deployment-matrix.yml and move the lerian-notification entry in the
Clotilde, Anacleto and Benedita cluster lists so it sits directly after the
product-console entry (matching Firmino’s ordering), ensuring each cluster’s app
list preserves the same relative position for lerian-notification as in Firmino.

---

Outside diff comments:
In @.github/workflows/backmerge.yml:
- Around line 145-149: The workflow currently creates a GitHub App token via the
actions/create-github-app-token step with id "app-token" but does not declare
any permission-* inputs, so the token inherits all installation permissions;
update the "app-token" step to add explicit permission-* inputs (e.g.,
permission-contents, permission-pull-requests, permission-issues, etc.) that
exactly match what the backmerge job needs and set repositories/owner inputs if
applicable to restrict scope, ensuring you choose the least-privilege set for
this job and replicate the same scoping in any other workflow steps that create
the same token.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6958b345-d88e-4c91-bfb0-cd8f0216c63f

📥 Commits

Reviewing files that changed from the base of the PR and between 94b8b32 and be68840.

📒 Files selected for processing (8)
  • .github/workflows/backmerge.yml
  • .github/workflows/gptchangelog.yml
  • .github/workflows/helm-update-chart.yml
  • .github/workflows/helm-upgrade-doc.yml
  • .github/workflows/release-notification.yml
  • .github/workflows/release.yml
  • .github/workflows/typescript-release.yml
  • config/deployment-matrix.yml

Comment thread config/deployment-matrix.yml
@bedatty bedatty merged commit 7025bd1 into main May 28, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Changes to changelog generation composite actions (src/changelog/) deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) notify Changes to notification composite actions (src/notify/) size/XS PR changes < 50 lines typescript Changes to TypeScript or Frontend workflows workflow Changes to one or more reusable workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants