Skip to content

fix(plugin-fees): bump backend version#795

Merged
guimoreirar merged 7 commits intomainfrom
develop
Nov 21, 2025
Merged

fix(plugin-fees): bump backend version#795
guimoreirar merged 7 commits intomainfrom
develop

Conversation

@guimoreirar
Copy link
Copy Markdown
Member

@guimoreirar guimoreirar commented Nov 21, 2025

Midaz Pull Request Checklist

Pull Request Type

  • Midaz
  • Plugin Access Manager
  • Plugin CRM
  • Reporter
  • Plugin Fees
  • Plugin BR PIX Direct JD
  • Otel Collector
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

Summary by CodeRabbit

  • Documentation

    • Helm install docs updated to use a flexible version placeholder; chart version mappings updated to reflect new versions.
  • Chores

    • Released Plugin Fees Helm Chart pre-release 3.4.4-beta.1
    • Fees component updated to 3.0.2
    • UI component updated to 3.0.0

✏️ Tip: You can customize this high-level summary in your review settings.

guimoreirar and others added 3 commits November 21, 2025 17:49
fix(plugin-fees): bump plugin-fees chart to version 3.4.4
##  (2025-11-21)

### Bug Fixes

* bump plugin-fees chart to version 3.4.4 ([8aaed46](8aaed46))
@guimoreirar guimoreirar requested a review from a team as a code owner November 21, 2025 20:54
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 21, 2025

Walkthrough

This pull request updates the Plugin Fees Helm chart metadata and image tags: charts/plugin-fees/Chart.yaml version bumped to 3.4.4-beta.1 and appVersion to 3.0.2; charts/plugin-fees/values.yaml updates fees.image.tag to 3.0.2 and frontend.image.tag to 3.0.0; charts/plugin-fees/README.md makes the Helm install version parametric by replacing a hard-coded version with <version>.

Possibly related PRs

Suggested reviewers

  • maciell1
  • ferr3ira-gabriel

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description follows the required template with the Plugin Fees type selected and two checklist items marked complete, but several important items remain unchecked including testing, documentation, and version updates. Consider completing unchecked critical items such as verifying tests pass, confirming version update appropriateness, and ensuring documentation reflects the new versions.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(plugin-fees): bump backend version' accurately reflects the main change: updating backend and frontend image tags in the Plugin Fees Helm chart.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2804056 and 941d8f3.

📒 Files selected for processing (1)
  • charts/plugin-fees/Chart.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • charts/plugin-fees/Chart.yaml

Comment @coderabbitai help to get the list of available commands and usage tips.

@guimoreirar guimoreirar changed the title Develop fix(plugin-fees): bump backend version Nov 21, 2025
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
charts/plugin-fees/README.md (1)

81-81: Update stale parameter table defaults to match values.yaml.

The parameter documentation table lists incorrect default values that no longer match the actual defaults in values.yaml. This can cause user confusion and deployment errors:

  • Line 81: fees.image.tag listed as 1.0.0, but values.yaml shows 3.0.2
  • Line 117: frontend.image.tag listed as 2.0.0-beta.12, but values.yaml shows 3.0.0
  • Line 127: frontend.service.port listed as 8081, but values.yaml shows 8084

Apply this diff to update the table:

-| `fees.image.tag` | Image tag used for deployment | `1.0.0` |
+| `fees.image.tag` | Image tag used for deployment | `3.0.2` |
-| `frontend.image.tag` | Image tag used for deployment | `2.0.0-beta.12` |
+| `frontend.image.tag` | Image tag used for deployment | `3.0.0` |
-| `frontend.service.port` | Service port | `8081` |
+| `frontend.service.port` | Service port | `8084` |

Also applies to: 117-117, 127-127

🧹 Nitpick comments (1)
charts/plugin-fees/README.md (1)

273-273: Minor: Fix whitespace indentation inconsistency.

Lines 273 and 287 have extra leading whitespace that doesn't match the surrounding comment style. Apply this diff to normalize:

-   # -- Tolerations for scheduling on tainted nodes
+  # -- Tolerations for scheduling on tainted nodes
-   # -- ConfigMap for environment variables and configurations
+  # -- ConfigMap for environment variables and configurations

Also applies to: 287-287

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2da877f and 2804056.

📒 Files selected for processing (4)
  • README.md (1 hunks)
  • charts/plugin-fees/Chart.yaml (1 hunks)
  • charts/plugin-fees/README.md (1 hunks)
  • charts/plugin-fees/values.yaml (2 hunks)
🔇 Additional comments (2)
charts/plugin-fees/values.yaml (1)

19-19: Image tag updates are correct and consistent.

The version bumps for both fees (3.0.2) and frontend (3.0.0) are well-aligned with the root README.md version mapping. However, note that the parameter tables in charts/plugin-fees/README.md have stale default values for these image tags and will need to be updated to avoid confusion during deployments.

Please verify that the README.md parameter documentation tables (particularly line 81 for fees.image.tag and line 117 for frontend.image.tag) are updated to reflect the new defaults.

Also applies to: 176-176

charts/plugin-fees/README.md (1)

12-12: Good improvement: parametric version placeholder in install command.

The update from hard-coded 1.0.0 to <version> makes the documentation more flexible and maintainable.

Comment thread charts/plugin-fees/Chart.yaml Outdated
Comment thread README.md
##  (2025-11-21)

### Bug Fixes

* bump plugin-fees chart to version 3.4.4 ([8aaed46](8aaed46))
@guimoreirar guimoreirar self-assigned this Nov 21, 2025
@guimoreirar guimoreirar merged commit b978381 into main Nov 21, 2025
7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 24, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants