fix(plugin-fees): bump backend version#795
Conversation
fix(plugin-fees): bump plugin-fees chart to version 3.4.4
WalkthroughThis pull request updates the Plugin Fees Helm chart metadata and image tags: Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
chore: bump plugin-fees application version to 3.0.2
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
charts/plugin-fees/README.md (1)
81-81: Update stale parameter table defaults to match values.yaml.The parameter documentation table lists incorrect default values that no longer match the actual defaults in
values.yaml. This can cause user confusion and deployment errors:
- Line 81:
fees.image.taglisted as1.0.0, but values.yaml shows3.0.2- Line 117:
frontend.image.taglisted as2.0.0-beta.12, but values.yaml shows3.0.0- Line 127:
frontend.service.portlisted as8081, but values.yaml shows8084Apply this diff to update the table:
-| `fees.image.tag` | Image tag used for deployment | `1.0.0` | +| `fees.image.tag` | Image tag used for deployment | `3.0.2` |-| `frontend.image.tag` | Image tag used for deployment | `2.0.0-beta.12` | +| `frontend.image.tag` | Image tag used for deployment | `3.0.0` |-| `frontend.service.port` | Service port | `8081` | +| `frontend.service.port` | Service port | `8084` |Also applies to: 117-117, 127-127
🧹 Nitpick comments (1)
charts/plugin-fees/README.md (1)
273-273: Minor: Fix whitespace indentation inconsistency.Lines 273 and 287 have extra leading whitespace that doesn't match the surrounding comment style. Apply this diff to normalize:
- # -- Tolerations for scheduling on tainted nodes + # -- Tolerations for scheduling on tainted nodes- # -- ConfigMap for environment variables and configurations + # -- ConfigMap for environment variables and configurationsAlso applies to: 287-287
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
README.md(1 hunks)charts/plugin-fees/Chart.yaml(1 hunks)charts/plugin-fees/README.md(1 hunks)charts/plugin-fees/values.yaml(2 hunks)
🔇 Additional comments (2)
charts/plugin-fees/values.yaml (1)
19-19: Image tag updates are correct and consistent.The version bumps for both fees (
3.0.2) and frontend (3.0.0) are well-aligned with the root README.md version mapping. However, note that the parameter tables incharts/plugin-fees/README.mdhave stale default values for these image tags and will need to be updated to avoid confusion during deployments.Please verify that the README.md parameter documentation tables (particularly line 81 for
fees.image.tagand line 117 forfrontend.image.tag) are updated to reflect the new defaults.Also applies to: 176-176
charts/plugin-fees/README.md (1)
12-12: Good improvement: parametric version placeholder in install command.The update from hard-coded
1.0.0to<version>makes the documentation more flexible and maintainable.
Midaz Pull Request Checklist
Pull Request Type
Checklist
Please check each item after it's completed.
Additional Notes
Obs: Please, always remember to target your PR to develop branch instead of main.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.