Skip to content

fix(ci): align workflows with shared workflows 1.30.0 boilerplate#16

Merged
bedatty merged 2 commits into
developfrom
ci/refresh-shared-workflows-1.30.0
May 26, 2026
Merged

fix(ci): align workflows with shared workflows 1.30.0 boilerplate#16
bedatty merged 2 commits into
developfrom
ci/refresh-shared-workflows-1.30.0

Conversation

@bedatty
Copy link
Copy Markdown
Contributor

@bedatty bedatty commented May 26, 2026

Lerian

Lib SystemPlane


Description

Aligns the repository .github/ with the LerianStudio shared-workflows convention (pinned @v1.30.0), using lib-commons as the reference. Replaces the bespoke release.yml (inline GPG/app-token/semantic-release/backmerge) and the hand-rolled go-combined-analysis.yml with the shared reusable workflows, and adds the missing standardized pieces (PR validation, PR security scan, routines, labeler/labels mirror).

Repo-specific decisions preserved:

  • Integration tests stay enabled via the shared go-pr-analysis (enable_integration_tests: true, make test-integration LOW_RESOURCE=1) — this repo has real testcontainers (mongo/postgres) coverage that lib-commons does not.
  • AC15 perf gate kept as a custom job (go test -tags=unit -run=^TestPerf_ ./...), same pattern lib-commons uses.
  • enable_docker_scan: false (no Dockerfile); no ignore_file (no .trivyignore).
  • Scopes (pr_title_scopes, labeler, labels) derived from the repo structure: admin, client, debounce, mongodb, postgres, store, systemplanetest, core, plus the standard transversal scopes.

Type of Change

  • ci: CI pipeline or workflow changes

Breaking Changes

None.

Testing

  • Validated by the workflows triggered on this PR (PR Validation, Go Combined Analysis, PR Security Scan).

Test evidence / Actions run: see the Checks tab on this PR.

Architectural Checklist

  • CI pinned to shared workflows @v1.30.0 (backmerge @v1)
  • .github/** excluded from code-analysis paths-ignore, but kept in security scan triggers (supply-chain)
  • PRs enforced to target develop (enforce_source_branches)

Related Issues

Closes #

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR consolidates GitHub Actions workflows and CI/CD configuration by migrating to shared reusable workflows, expanding Dependabot automation rules with scheduling and grouping, introducing comprehensive PR label management and governance (template, validation, labeling rules), and adding new security and routine automation workflows.

Changes

GitHub Actions and CI/CD Consolidation

Layer / File(s) Summary
Dependency and Label Configuration
.github/dependabot.yml, .github/labels.yml, .github/labeler.yml
Dependabot configuration expanded with schedule specificity (day, time, timezone), open-PR limits, and update grouping for gomod and github-actions. Complete label ecosystem added covering scopes, change types, PR sizing, triage/stale controls, and automation labels. PR labeler maps file path changes to labels across admin, client, storage, scripts, CI, docs, tests, and dependency areas.
Pull Request Template and Validation
.github/pull_request_template.md, .github/workflows/pr-validation.yml
PR template restructured with sections for description, change type, breaking changes, testing evidence, and architectural checklist. Validation workflow enforces allowed source branches (develop, hotfix/*) and restricts PR title scopes to a fixed allowlist (admin, ci, docs, deps, mongodb, postgres, tests, etc.).
Go Analysis Workflow Migration
.github/workflows/go-combined-analysis.yml
Prior standalone jobs (golangci-lint, unit/build, integration, GoSec) consolidated into single go-analysis job calling shared workflow at v1.30.0. Trigger simplified with paths-ignore for docs/license, permissions reduced to read-only, and perf-gate job maintained with minimal steps.
Pull Request Security Scanning Workflow
.github/workflows/pr-security-scan.yml
New workflow scanning PRs targeting develop and main, ignoring doc/license changes, with Docker and CodeQL explicitly disabled while inheriting secrets from shared security workflow.
Release and Backmerge Workflow Migration
.github/workflows/release.yml
Prior in-repo release validation, semantic versioning, GPG configuration, and backmerge logic replaced with release job (conditional changelog on main) and backmerge job (label/rule inputs) both delegating to shared workflows at v1.30.0.
Repository Routine Automation Workflow
.github/workflows/routine.yml
New workflow handling repository maintenance tasks via shared workflow, triggered on schedule (weekly cron), push to main when labels.yml changes, PR close, and manual dispatch with routine selection and dry-run toggle.

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio lerian-studio added size/L PR changes 500–999 lines ci Continuous integration pipelines docs Documentation and markdown content labels May 26, 2026
@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 26, 2026

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 26, 2026

📊 Unit Test Coverage Report: app

Metric Value
Overall Coverage 38.1% ⚠️ BELOW THRESHOLD
Threshold 80%

Coverage by Package

Package Coverage
github.com/LerianStudio/lib-systemplane/admin 80.3%
github.com/LerianStudio/lib-systemplane/examples/manager 0.0%
github.com/LerianStudio/lib-systemplane/internal/client 46.2%
github.com/LerianStudio/lib-systemplane/internal/debounce 73.1%
github.com/LerianStudio/lib-systemplane/internal/manager 74.4%
github.com/LerianStudio/lib-systemplane/internal/mongodb 15.7%
github.com/LerianStudio/lib-systemplane/internal/postgres 7.2%
github.com/LerianStudio/lib-systemplane/systemplanetest 0.0%
github.com/LerianStudio/lib-systemplane 0.0%

Generated by Go PR Analysis workflow

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 26, 2026

🔒 Security Scan Results — lib-systemplane

✅ PR Mergeable — no blocking findings

Stage Status Blocking?
Filesystem Scan ✅ Clean
Docker Image Scan ➖ Skipped
Docker Hub Health Score ➖ Skipped
Pre-release Version Check ✅ Clean

Trivy

Filesystem Scan

✅ No vulnerabilities or secrets found.


Pre-release Version Check

✅ No unstable version pins found.


🔍 View full scan logs

@lerian-studio lerian-studio added the scripts Build and tooling scripts label May 26, 2026
@bedatty bedatty merged commit 781d3d1 into develop May 26, 2026
19 of 22 checks passed
@github-actions github-actions Bot deleted the ci/refresh-shared-workflows-1.30.0 branch May 26, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration pipelines docs Documentation and markdown content scripts Build and tooling scripts size/L PR changes 500–999 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants