Skip to content

fix(scripts): remove trailing blank line from Makefile#19

Merged
bedatty merged 1 commit into
developfrom
test/trigger-release-makefile
May 26, 2026
Merged

fix(scripts): remove trailing blank line from Makefile#19
bedatty merged 1 commit into
developfrom
test/trigger-release-makefile

Conversation

@bedatty
Copy link
Copy Markdown
Contributor

@bedatty bedatty commented May 26, 2026

Description

Remove a linha em branco final adicionada anteriormente ao Makefile, e serve para disparar o release.yml no develop (mudança fora do paths-ignore).

Após o backmerge da #18, o develop já contém v1.4.0 no histórico. Este merge dispara o semantic-release, que agora parte de 1.4.0 como baseline e deve cortar v1.5.0-beta.1 (há commits feat desde v1.4.0 → minor).

Type of Change

  • chore: Maintenance, config, tooling

Breaking Changes

None.

Related Issues

Closes #

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6e25c920-3e72-4bf0-b371-2c6e8f7d8ae9

📥 Commits

Reviewing files that changed from the base of the PR and between 67a22df and 2ac8756.

📒 Files selected for processing (1)
  • Makefile
💤 Files with no reviewable changes (1)
  • Makefile

Walkthrough

The goreleaser Makefile target recipe is updated to invoke goreleaser release with --snapshot --skip=publish --clean flags and append a success confirmation message after execution, replacing the previous recipe implementation.

Changes

Goreleaser Target

Layer / File(s) Summary
Goreleaser snapshot release target
Makefile
The goreleaser target recipe is updated to run goreleaser with snapshot, publish-skip, and clean flags, then prints a success message upon completion.

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio lerian-studio added size/XS PR changes < 50 lines scripts Build and tooling scripts labels May 26, 2026
@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 26, 2026

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio
Copy link
Copy Markdown
Contributor

🔒 Security Scan Results — lib-systemplane

✅ PR Mergeable — no blocking findings

Stage Status Blocking?
Filesystem Scan ✅ Clean
Docker Image Scan ➖ Skipped
Docker Hub Health Score ➖ Skipped
Pre-release Version Check ✅ Clean

Trivy

Filesystem Scan

✅ No vulnerabilities or secrets found.


Pre-release Version Check

✅ No unstable version pins found.


🔍 View full scan logs

@bedatty bedatty changed the title chore(scripts): remove trailing blank line from Makefile fix(scripts): remove trailing blank line from Makefile May 26, 2026
@lerian-studio
Copy link
Copy Markdown
Contributor

📊 Unit Test Coverage Report: app

Metric Value
Overall Coverage 38.1% ⚠️ BELOW THRESHOLD
Threshold 80%

Coverage by Package

Package Coverage
github.com/LerianStudio/lib-systemplane/admin 80.3%
github.com/LerianStudio/lib-systemplane/examples/manager 0.0%
github.com/LerianStudio/lib-systemplane/internal/client 46.2%
github.com/LerianStudio/lib-systemplane/internal/debounce 73.1%
github.com/LerianStudio/lib-systemplane/internal/manager 74.4%
github.com/LerianStudio/lib-systemplane/internal/mongodb 15.7%
github.com/LerianStudio/lib-systemplane/internal/postgres 7.2%
github.com/LerianStudio/lib-systemplane/systemplanetest 0.0%
github.com/LerianStudio/lib-systemplane 0.0%

Generated by Go PR Analysis workflow

@bedatty bedatty merged commit 87e63ad into develop May 26, 2026
26 of 27 checks passed
@github-actions github-actions Bot deleted the test/trigger-release-makefile branch May 26, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scripts Build and tooling scripts size/XS PR changes < 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants