Fixed plot saving logic and added selenium as a dependency.#252
Merged
pauladkisson merged 3 commits intomainfrom Mar 31, 2026
Merged
Fixed plot saving logic and added selenium as a dependency.#252pauladkisson merged 3 commits intomainfrom
pauladkisson merged 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Tests and coverage of this fix will be handled in #250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the save button on the visualization dashboard would throw an error instead of properly saving the plots.
Since Firefox is only available on Conda Forge and not PyPI, I've opted for a solution of explicitly passing a web driver to the export functions, which keeps GuPPy pip installable.