Cross-correlation: raise ValueError when fewer than two signal regions are present and surface error to frontend UI#284
Conversation
…ignal regions Agent-Logs-Url: https://github.com/LernerLab/GuPPy/sessions/5e225688-eb0d-40ff-be9d-78714b739f3e Co-authored-by: pauladkisson <34703136+pauladkisson@users.noreply.github.com>
pauladkisson
left a comment
There was a problem hiding this comment.
This actually looks pretty good on the backend side, but I would like this error message to surface to the frontend so that users know that something has gone wrong when they click step five and they don't have to go digging into the terminal.
Agent-Logs-Url: https://github.com/LernerLab/GuPPy/sessions/44516815-80e5-487a-bfbb-da4264333d66 Co-authored-by: pauladkisson <34703136+pauladkisson@users.noreply.github.com>
Done in commit 797e3a0. The error message is now surfaced to the Panel UI via a toast notification:
|
pauladkisson
left a comment
There was a problem hiding this comment.
This looks amazing. The error pop-up is beautiful.
|
@copilot please update the change log. |
Agent-Logs-Url: https://github.com/LernerLab/GuPPy/sessions/3aa24ae1-7be2-479d-8785-6ff1dff16708 Co-authored-by: pauladkisson <34703136+pauladkisson@users.noreply.github.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
pauladkisson
left a comment
There was a problem hiding this comment.
Unfortunately, these tests fail on Windows due to threading and file lock issues. I think the cleanest solution to this problem is to mark those tests as progress bar tests and/or something like that. I think progress bar tests, and then skip them in the CI so that they don't run on Windows, but they can be run locally. Add a pragma: no cover to the read PB increment values function, along with a comment explaining why it cannot be tested with a reference to this issue.
…readPBIncrementValues Agent-Logs-Url: https://github.com/LernerLab/GuPPy/sessions/7159dbbd-a7a0-477a-8676-107700b03ffc Co-authored-by: pauladkisson <34703136+pauladkisson@users.noreply.github.com>
Done in commit 3363c4e:
|
ValueErrorinexecute_compute_cross_correlationwhen fewer than two signal regions are present (single-region and zero-region messages)getCorrCombinationsto return single region name instead of empty listPB_ERROR_FILEmechanism andpn.state.notifications.errorreadPBIncrementValuestests with@pytest.mark.progress_bar; skip on Windows in CI; add# pragma: no covertoreadPBIncrementValues(see issue Refactor progress bar to remove file-based backend #286)