Skip to content

Fixed floating point store names bug#294

Merged
pauladkisson merged 3 commits intomainfrom
split_storename
Apr 27, 2026
Merged

Fixed floating point store names bug#294
pauladkisson merged 3 commits intomainfrom
split_storename

Conversation

@pauladkisson
Copy link
Copy Markdown
Collaborator

Fixes #289

In TDT, split storenames with floating-point values (ex Widt=0.1) will be replaced with a p (ex. Widt0p1).

@pauladkisson
Copy link
Copy Markdown
Collaborator Author

@MannyEsguerra, this should fix your issue.

Do I have your permission to include a stubbed version of the session that you shared in our testing suite so that we can confirm that this bug never re-surfaces?

@MannyEsguerra
Copy link
Copy Markdown

MannyEsguerra commented Apr 26, 2026

@pauladkisson thank you! Feel free to include that TDT session in your testing suite.

Sorry I don't understand how versioning works, will we be able to download and use the fixed code soon?

@pauladkisson
Copy link
Copy Markdown
Collaborator Author

@pauladkisson thank you! Feel free to include that TDT session in your testing suite.

Great, thank you.

Sorry I don't understand how versioning works, will we be able to download and use the fixed code soon?

It's not available just yet, but as soon as the fix gets merged, I'll go ahead and make an alpha release and let you know.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pauladkisson pauladkisson marked this pull request as ready for review April 27, 2026 16:11
@pauladkisson pauladkisson merged commit 3d14567 into main Apr 27, 2026
13 of 16 checks passed
@pauladkisson pauladkisson deleted the split_storename branch April 27, 2026 16:28
@MannyEsguerra
Copy link
Copy Markdown

Thank you Paul!

@pauladkisson
Copy link
Copy Markdown
Collaborator Author

@MannyEsguerra just want to keep you in the loop. I just have one thing to wrap up before I make the release (#299), which should be done sometime tomorrow.

@pauladkisson
Copy link
Copy Markdown
Collaborator Author

@MannyEsguerra, I just made an alpha release with the fix included. All you need to do is update your installation of Guppy, and it should work on your data now.

pip install -U guppy-neuro

@MannyEsguerra
Copy link
Copy Markdown

Fantastic news! We'll check it out tomorrow. Thanks very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visualization crashing on storenames with '.' character

2 participants