Validate numeric form inputs at entry-time (LiteralInput → IntInput)#297
Merged
pauladkisson merged 3 commits intomainfrom Apr 27, 2026
Merged
Validate numeric form inputs at entry-time (LiteralInput → IntInput)#297pauladkisson merged 3 commits intomainfrom
pauladkisson merged 3 commits intomainfrom
Conversation
… IntInput Rejects non-numeric input at the browser level via native <input type="number"> instead of silently reverting to the previous valid value, matching the treatment already applied to baseline_wd_strt / baseline_wd_end in PR #283. Closes #291 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LiteralInput(type=int, ...)widgets insrc/guppy/frontend/input_parameters.pywithpn.widgets.IntInput(...)so non-numeric input is rejected at the browser level (native<input type="number">) instead of being silently reverted to the previous valid value.timeForLightsTurnOn,numberOfCores,moving_wd,highAmpFilt,transientsThresh,moving_avg_filter,no_channels_np,nSecPrev,nSecPost,timeInterval,bin_psth_trials,baselineCorrectionStart,baselineCorrectionEnd.baseline_wd_strt/baseline_wd_end. Closes Validate parameter form inputs at entry-time instead of silently reverting #291.Test plan
pytest tests/unit/frontend/test_input_parameters.py -v(47 passed)🤖 Generated with Claude Code