Skip to content

chore : swagger 보안 수정#18

Merged
Juhye0k merged 2 commits intodevfrom
item
Aug 7, 2025
Merged

chore : swagger 보안 수정#18
Juhye0k merged 2 commits intodevfrom
item

Conversation

@Juhye0k
Copy link
Copy Markdown
Contributor

@Juhye0k Juhye0k commented Aug 7, 2025

What is this PR?🔍

  • Spring Security로 인한 Swagger 접근 에러 발생 해결

Summary by CodeRabbit

  • 신규 기능
    • Swagger 관련 엔드포인트(/swagger-ui.html, /v3/api-docs/**, v3/api-docs/swagger-config)에 대한 공개 접근이 허용되었습니다.
  • 기타
    • 기존 공개 URL 패턴 외에 추가적으로 Swagger 문서 관련 경로가 허용되어 API 문서 접근이 더 편리해졌습니다.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 7, 2025

Warning

Rate limit exceeded

@Juhye0k has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2ece9a2 and 6a6302b.

📒 Files selected for processing (1)
  • src/main/java/avengers/lion/global/config/security/SecurityConfig.java (1 hunks)

Walkthrough

HTTP 요청 보안 구성이 수정되어 Swagger 관련 엔드포인트(/swagger-ui.html, /v3/api-docs/**, v3/api-docs/swagger-config)가 공개적으로 접근 가능한 URL 패턴에 추가되었습니다. 기존 공개 경로 외 나머지 요청은 여전히 인증이 필요합니다.

Changes

Cohort / File(s) Change Summary
SecurityConfig 공개 URL 패턴 확장
src/main/java/avengers/lion/global/config/security/SecurityConfig.java
Swagger 관련 엔드포인트를 공개 접근 허용 URL 목록에 추가함. 기존 인증 정책은 유지됨.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰
Swagger 길이 활짝 열렸네,
토끼가 뛰어놀며 문을 지키네.
인증의 문턱은 여전히 높지만,
문서의 길은 누구나에게 활짝!
코드 속 보안, 살짝 더 친절해진 오늘,
당근 한 입, 기분 좋은 변화!

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch item

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/main/java/avengers/lion/global/config/security/SecurityConfig.java (1)

44-45: 코드 포맷팅 개선을 고려해보세요.

현재 .requestMatchers() 호출이 한 줄에 너무 많은 내용을 포함하고 있어 가독성이 떨어집니다.

더 나은 가독성을 위해 다음과 같이 포맷팅할 수 있습니다:

-                        .requestMatchers("/", "/oauth2/**", "/login/**", "/error", "/swagger-ui/**"
-                        ,"/swagger-ui.html", "/v3/api-docs/**", "/swagger-ui.html", "v3/api-docs/swagger-config").permitAll()
+                        .requestMatchers(
+                                "/", 
+                                "/oauth2/**", 
+                                "/login/**", 
+                                "/error",
+                                "/swagger-ui/**",
+                                "/swagger-ui.html",
+                                "/v3/api-docs/**",
+                                "/v3/api-docs/swagger-config"
+                        ).permitAll()
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f809465 and 2ece9a2.

📒 Files selected for processing (1)
  • src/main/java/avengers/lion/global/config/security/SecurityConfig.java (1 hunks)

@Juhye0k Juhye0k merged commit 975212b into dev Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant