It would be helpful for DesignSpace Problems to include check for inconsistent unicodes

[arrowtype]

I've just learned the hard way how painful it can be if unicodes mismatch in sources when you are trying to build a variable font.

Because of this, I believe it would be useful for DesignspaceProblems to include a check for inconsistent unicodes between fonts. If this were in place, it would presumably be a little faster for designers to catch this issue.

Thanks for such a useful tool!

[LettError]

Problem 4.10 is raised when the count of each collected unicode differs from the number of masters for that glyph. This allows multiple unicodes per master, as long as every master has them.

[LettError]

[arrowtype]

Thanks, Erik!

Is this a new feature? If it's not, do you know offhand if it also works if some masters are missing a unicode value for a glyph, while others have one? Back on Nov 11, it missed this scenario in my case.

[LettError]

I think it does, but it is new code.

DesignspaceProblems/Lib/designspaceProblems/__init__.py

Line 39 in c0dc16a

def add(self, glyph):

For each glyph, get the unicodes and count them. Add None if it hasn’t one. Then after doing all the masters, the count for each Unicode should be the same as the number of masters. Whenever a Unicode has too few counts, report it. I think that covers it.

[arrowtype]

So, I've tried to make a smaller test case, to check on this. I've found that especially if multiple people are working on a larger character set and building new glyphs with something like Glyph Construction, this kind of problem is quite easy to run into.

I thought that it might miss a couple of different scenarios, but I've done a test, and it seems to be working in each way I can think of.

https://github.com/arrowtype/designspace_problems-unicode-test

▶ python designspace_problems-unicode-test.py

[[glyphs: different unicodes in glyph, glyphName: C unicodes: [73] (4, 10)],
[glyphs: different unicodes in glyph, glyphName: B unicodes: [None, 66] (4, 10)],
[glyphs: different unicodes in glyph, glyphName: A unicodes: [65, 128] (4, 10)]]

Before this, I tried the simpler test of this designspace in the DesignspaceEditor, but it didn't report these problems. I guess maybe that extension just hasn't quite been updated yet?

Cheers for adding/improving these tests! As far as I know, this issue is fine to close.

[LettError]

Thanks for this test, @arrowtype! I posted an update for DesignspaceEdit. Aside, I need to review whether it is still necessary to embed designspaceProblems in designspaceEdit.

[LettError]

Ok, Fixed.