This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Merged
Conversation
vweevers
reviewed
May 27, 2018
| ## API | ||
|
|
||
| ### `db = leveljs(location[, options])` | ||
| Returns a new `leveljs` instance. `location` is a String pointing to the IndexedDB location to be opened. |
Member
There was a problem hiding this comment.
-`location` is a String pointing to the IndexedDB location to be opened
+`location` is the string name of the IndexedDB object store to be opened
Member
There was a problem hiding this comment.
Nah, that's not quite it either. It also controls the IndexedDB database name.
Member
Author
There was a problem hiding this comment.
@vweevers Think about it for a bit. I'll do other stuff meanwhile.
Member
There was a problem hiding this comment.
How about: location is the string name of the IDBDatabase to be opened, as well as the object store within that database. The database name will be prefixed with options.prefix.
vweevers
reviewed
May 27, 2018
|
|
||
| The optional `options` argument may contain: | ||
|
|
||
| * `prefix` *(string, default: `'level-js-'`)*: Prepended to the location for the underlying IndexedDB store. |
Member
There was a problem hiding this comment.
And here we can say: "Prefix for IDBDatabase name"
vweevers
approved these changes
May 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103