This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Closed
Conversation
Member
|
👍 Should we merge it directly, or merge as a single branch? |
Member
Author
|
the branch name is missleading, i'll create separate branches for further fixes |
timkuijsten
pushed a commit
to timkuijsten/level.js
that referenced
this pull request
Feb 4, 2016
Fixes Level#43 Level#40 and Level#3. Unfortunately not easy to split out in separate commits. 1. Level#43 "snapshots seem not to work" The reason snapshots didn't work in the test, is because the iterator was only opened on the first call to _next. The new version opens the iterator right away in the constructor (if there is no KeyRange error). 2. Level#40 "abstract-leveldown tests aren't all passing anymore" Partially fixed by merging PR Level#42 and further fixed by this commit. 3. Level#3 "stop batch reads after limit is reached" The solution is stop calling cursor.continue() once the limit is reached. The transaction will automatically timeout as prescribed by the spec. idb-wrapper can't be used for this because limit is only respected if autoContinue is true. All 563 tests pass on: * Safari 9.0.3 * Firefox 45.0b2 * Firefox 46.0a2 * Iridium 44.1 (Chrome/44.0.2403.157)
mvayngrib
pushed a commit
to mvayngrib/level.js
that referenced
this pull request
Aug 21, 2016
Fixes Level#43 Level#40 and Level#3. Unfortunately not easy to split out in separate commits. 1. Level#43 "snapshots seem not to work" The reason snapshots didn't work in the test, is because the iterator was only opened on the first call to _next. The new version opens the iterator right away in the constructor (if there is no KeyRange error). 2. Level#40 "abstract-leveldown tests aren't all passing anymore" Partially fixed by merging PR Level#42 and further fixed by this commit. 3. Level#3 "stop batch reads after limit is reached" The solution is stop calling cursor.continue() once the limit is reached. The transaction will automatically timeout as prescribed by the spec. idb-wrapper can't be used for this because limit is only respected if autoContinue is true. All 563 tests pass on: * Safari 9.0.3 * Firefox 45.0b2 * Firefox 46.0a2 * Iridium 44.1 (Chrome/44.0.2403.157)
Merged
Member
|
Superseded by #68. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is another fix required for the new abstract-leveldown