Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.
/ level-js Public archive

Cleanup#97

Merged
vweevers merged 9 commits intomasterfrom
cleanup
May 26, 2018
Merged

Cleanup#97
vweevers merged 9 commits intomasterfrom
cleanup

Conversation

@vweevers
Copy link
Member

@vweevers vweevers commented May 25, 2018

Closes #95, closes #80, closes #87, restructures the tests.

@vweevers vweevers requested a review from ralphtheninja May 25, 2018 18:00
'use strict'

exports.binaryKeys = function (impl) {
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! And the immediate thing too (to be used by memdown and level-js).

@ralphtheninja
Copy link
Member

Bad ass work!

@vweevers vweevers merged commit 12e9294 into master May 26, 2018
@vweevers vweevers deleted the cleanup branch May 26, 2018 05:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move mixedToBuffer to utils/ Use setImmediate Remove manual/end-test.js after refactoring is done

2 participants