This repository was archived by the owner on Dec 1, 2024. It is now read-only.
extracted ReadStream state manager, fixes #82#84
Merged
Conversation
Member
Author
|
merging this in lieu of feedback, I'd like to get a fix out there, we can clean up later if anyone objects to my approach. |
rvagg
added a commit
that referenced
this pull request
Mar 1, 2013
extracted ReadStream state manager, fixes #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also #83
Too much magic going on with
this._status, extracted it to a separate state object (something like a state machine) with explicit logic for what can happen in the different states.Is this lame? I'm just sick of managing readable stream state under complex async conditions so I figure being clear & explicit about it is the safest way to go.