Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.
/ memdown Public archive

Use immediate in browsers, setImmediate in Node#61

Merged
nolanlawson merged 1 commit intomasterfrom
immediate2
Nov 19, 2016
Merged

Use immediate in browsers, setImmediate in Node#61
nolanlawson merged 1 commit intomasterfrom
immediate2

Conversation

@nolanlawson
Copy link
Contributor

See #59 (comment) for backstory.

@calvinmetcalf
Copy link
Contributor

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8d952e7 on immediate2 into 0fb34b3 on master.

@juliangruber
Copy link
Member

i think this can be simplified by removing immediate-browser.js and having "./immediate.js": "immediate" in the package.json?

@nolanlawson
Copy link
Contributor Author

@juliangruber The reason I don't do that is that that pattern breaks in Webpack and Rollup. Or at least it used to. So I don't trust it anymore.

@nolanlawson nolanlawson merged commit 304a401 into master Nov 19, 2016
@juliangruber juliangruber deleted the immediate2 branch November 20, 2016 10:02
@juliangruber
Copy link
Member

@juliangruber The reason I don't do that is that that pattern breaks in Webpack and Rollup. Or at least it used to. So I don't trust it anymore.

Meh, ok!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants