Skip to content

Conversation

@npilon
Copy link
Member

@npilon npilon commented Aug 28, 2020

To test:

  - repo: https://github.com/LexMachinaInc/precommit-per-file-flake8.git
    rev: "all-file-returns"
    hooks:
      - id: flake8-file
        additional_dependencies:
          - flake8-import-order

In .pre-commit-config.yaml

Then try to commit something involving one bad file and multiple good files.

Copy link

@MarissaSkud MarissaSkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Flake8 didn't catch the unused imports error on my test branch when I had rev: 0.2.0 in my .pre-commit-config.yml, but it caught them when I switched it to rev: all-file-returns.

Will it also be necessary to open a pull request in the deus_lex repo to update it to rev: 0.4.0?

@MarissaSkud
Copy link

@npilon wait, I now have review/comment access to this repo, but I still don't have write access. Can't merge this in but I give it my approval!

@npilon npilon merged commit 5a1f4f7 into main Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants