Add tests with module type inclusion #49
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new pattern was observed on Frama-C. It is described in `examples/using_dune/lib/values/builder_sig_api/README.md`. It uses a mix of module types, functors and includes dispatched in multiple files. It is not uncommon to use a `.ml` (without `.mli`) to expose module types and reuse these in other module's `.mli`. This pattern will need to be tested more specifically. The new tests results (`.ref`) expose a minor bug in the test engine. This should be easy to fix.
The comparison was on the whole line at one to obtain a lexicographical order. The tests in the previous commit show that this ordering is to shallow for report lines. Instead, they should be compared closer to how the analyzer does it : by filename first, then by line (the analyzer actually has more precise locations internally), then by value.
It is not uncommon to use a `.ml` (without `.mli`) to expose module types and include these in other module's `.mli`. The new tests specifically target this pattern with a toplevel `include`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not uncommon to use a
.ml(without.mli) to expose module types and include these in other module's.mli. A minimal example of this pattern is reproduced inexamples/using_dune/lib/values/include_modtype.A more complex pattern, found in Frama-C, is reproduced in
examples/using_dune/lib/values/builder_sig_api. This is an extension of the above, with intermediate functors.This change includes a small fix in the test engine. The report line comparison was done on whole lines (for lexicographical order), rather than by parts. This means
foo.ml:9: ..was considered greater thanfoo.ml:10: ..., and thus expected to appear later in the reports, when in the reports the former is actually supposed to appear first. Because of this, the test reports could wrongly identify some FP and FN after an actual FP/FN.The FP and FN introduced are tracked by #50.