Skip to content

Fix login failure when raw schedule is empty #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Li357 merged 3 commits into from
Aug 11, 2020
Merged

Fix login failure when raw schedule is empty #51

Li357 merged 3 commits into from
Aug 11, 2020

Conversation

@Li357
Copy link
Owner

@Li357 Li357 commented Aug 11, 2020

Most likely fixes #41. Some users have empty schedules, e.g.

window._pageDataJson = '{"action":"Index","controller":"Teachers","userId":"5521"}';

There is no schedule property, leading to an undefined error later on. Not caught by TS since fetched data is any.

@Li357 Li357 marked this pull request as ready for review August 11, 2020 20:38
@Li357 Li357 merged commit ac8faea into master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unknown login issue

2 participants

@Li357