Fix text formatting #116
Fix text formatting #116
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/LiYanan2004/MarkdownView/blob/495ec347770254dfd78dc29dc62f1cd8995a83e4/Sources/MarkdownView/Renderers/Node Representations/InlineMathOrText.swift#L55-L56
When LaTeXSwiftUI is unavailable, makeBody still returns MarkdownNodeView(Text(text)). The refactor replaced MarkdownNodeView’s Text initializers with AttributedString/String versions, so this call no longer matches any initializer and the file fails to compile in configurations that omit the LaTeX dependencies (e.g. the default package without optional modules). The fallback branch should construct the node with the new string-based initializer instead.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Description
2.5.0 introduces an issue that would drop all text formatting -- This PR fixes that issue.
Comparison