Order same-day history sessions by completionDateTime#751
Merged
Conversation
MohamedKiouaz
force-pushed
the
fix/history
branch
from
0e402c2 to
182e41f
Compare
Contributor
Author
|
Tested, it works, I am not sure if the implementation is 100 right. |
LiamMorrow
approved these changes
May 8, 2026
Owner
LiamMorrow
left a comment
LiamMorrow
left a comment
There was a problem hiding this comment.
Yeah that seems reasonble. I'll be honest I'm not sure why the thenByDescending isn't doing exactly what this should be but 🤷 Love the new test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when addind 2 sessions on the same day, they appear in a random order in the history as the current ordering is made using date only.
This uses completionDateTime to order the sessions.