fix(forms): use real font refs in appearance streams#21
Merged
Conversation
Appearance stream generators were creating incomplete stub font dictionaries (Type/Subtype/BaseFont/Encoding only) instead of referencing the complete Type0 font objects built at save time. After flattening, PDF viewers couldn't render the glyph IDs because DescendantFonts, ToUnicode, and FontDescriptor were missing. EmbeddedFont now stores its pre-allocated PdfRef (set by PDFFonts.embed), and appearance builders reference it directly instead of creating stubs.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18 — form flatten with embedded fonts produces empty/incorrect output.
EmbeddedFontnow stores its pre-allocatedPdfRef(set byPDFFonts.embed()), and appearance builders reference it directly instead of creating stubs. This ensures flattened fields use the same complete font objects as non-flattened output.