fix: handle off-by-one xref subsection start in malformed PDFs#38
Merged
Mythie merged 2 commits intoLibPDF-js:mainfrom Feb 28, 2026
Merged
fix: handle off-by-one xref subsection start in malformed PDFs#38Mythie merged 2 commits intoLibPDF-js:mainfrom
Mythie merged 2 commits intoLibPDF-js:mainfrom
Conversation
Some PDFs have a malformed xref table where the subsection header reports the starting object number as 1 instead of 0, while the entries clearly start at object 0 (free list head with gen 65535). This shifted all object resolutions by one, causing wrong page count and infinite loops in extractPages. - Detect and correct the off-by-one in xref subsection parsing - Add cycle detection to ObjectCopier.getInheritedAttribute as defense-in-depth - Add unit test for xref correction and integration test with fixtures
Contributor
|
@redsuperbat is attempting to deploy a commit to the mythie's projects Team on Vercel. A member of the Team first needs to authorize it. |
Mythie
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PDFs have a malformed xref table where the subsection header reports the starting object number as 1 instead of 0, while the entries clearly start at object 0 (free list head with gen 65535). This shifted all object resolutions by one, causing wrong page count and infinite loops in extractPages.