libvnc: add ExtendedMouseButtons support#720
Open
marcofortina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ExtendedMouseButtons support for LibVNCServer/LibVNCClient.
The RFB ExtendedMouseButtons pseudo-encoding allows clients and servers to
negotiate extended PointerEvent messages with an extra button-state byte. This
is needed for mouse buttons beyond the legacy one-byte PointerEvent mask, such
as forward/back-capable devices and additional mouse buttons.
Changes
rfbEncodingExtendedMouseButtonsand named button masks up to button 15.rfbEncodingExtendedMouseButtonsinSetEncodings.rfbEncodingExtendedMouseButtons.Validation
Local validation:
git diff --check cmake -S . -B build-686-patch \ -DWITH_EXAMPLES=OFF \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-686-patch --parallel 1 ctest --test-dir build-686-patch --output-on-failureResult:
Notes
This implements the negotiated ExtendedMouseButtons protocol path without
changing the legacy PointerEvent behavior for peers that do not negotiate the
extension.
This PR does not add any LibVNC-specific wire protocol. It uses the standard
RFB ExtendedMouseButtons pseudo-encoding and keeps the feature opt-in through
normal
SetEncodingsnegotiation.Closes #686.