Conversation
A geneartor that sets num_gpus based on the x value
jlnav
reviewed
Sep 13, 2023
jlnav
reviewed
Sep 13, 2023
jlnav
reviewed
Sep 13, 2023
jlnav
reviewed
Sep 13, 2023
| # Seed random streams for each worker, particularly for gen_f | ||
| persis_info = add_unique_random_streams({}, nworkers + 1) | ||
| # Seed random streams for each worker, particularly for gen_f | ||
| ensemble.add_random_streams() |
Member
There was a problem hiding this comment.
You could use ensemble.persis_info = add_unique_random_streams({}, ensemble.nworkers + 1) if you think its more clear
Member
Author
There was a problem hiding this comment.
Good point. I'm realising it means an extra import (from tools) which is a pain.
Member
There was a problem hiding this comment.
Yeah. That's one of the reasons I made Ensemble.add_random_streams() originally, I think I forgot to mention. Avoid an import, keep it simple for 75% of our tests
jlnav
reviewed
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update forces tests.
For relevant forces tests
Other capabilities
Tests
Update tutorials