Skip to content

Small edits#1364

Merged
jlnav merged 4 commits intodevelopfrom
docs/small_question_branch
Jul 25, 2024
Merged

Small edits#1364
jlnav merged 4 commits intodevelopfrom
docs/small_question_branch

Conversation

@jmlarson1
Copy link
Copy Markdown
Member

No description provided.

running on nodes with different numbers of GPUs. In effect a
block of this many GPUs will be treated as a virtual node.
By default the GPUs on a node are treated as a group.
By default the GPUs on each node are treated as a group.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuds13 The last line might be confusing. Is that saying that even though the nodes might have different numbers of GPUs, the groups will be a different size by default?

@jmlarson1
Copy link
Copy Markdown
Member Author

Can someone help me understand the comment # parse_args defaults to False on line 25 of libensemble/tests/unit_tests/test_ensemble.py. Which parse_args call is being referred to?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (9ae722e) to head (fc9c440).
Report is 143 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1364      +/-   ##
===========================================
+ Coverage    73.92%   73.95%   +0.03%     
===========================================
  Files           90       90              
  Lines         8294     8294              
  Branches      1476     1476              
===========================================
+ Hits          6131     6134       +3     
+ Misses        1943     1942       -1     
+ Partials       220      218       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmlarson1 jmlarson1 requested review from jlnav and shuds13 July 24, 2024 13:24
@jlnav
Copy link
Copy Markdown
Member

jlnav commented Jul 24, 2024

Can someone help me understand the comment # parse_args defaults to False on line 25 of libensemble/tests/unit_tests/test_ensemble.py. Which parse_args call is being referred to?

For a bit we've been able to do: ensemble = Ensemble(parse_args=True), which calls parse_args() underneath.

@jmlarson1
Copy link
Copy Markdown
Member Author

Can someone help me understand the comment # parse_args defaults to False on line 25 of libensemble/tests/unit_tests/test_ensemble.py. Which parse_args call is being referred to?

For a bit we've been able to do: ensemble = Ensemble(parse_args=True), which calls parse_args() underneath.

I guess that isn't clear from how I read that line. Can we add a bit to the comment to help?

@jlnav jlnav merged commit de3d18a into develop Jul 25, 2024
@shuds13 shuds13 deleted the docs/small_question_branch branch July 26, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants