Skip to content

Handling new ibcdfo exit flag#1436

Merged
jlnav merged 1 commit intodevelopfrom
bugfix_ibcdfo_new_flag
Oct 7, 2024
Merged

Handling new ibcdfo exit flag#1436
jlnav merged 1 commit intodevelopfrom
bugfix_ibcdfo_new_flag

Conversation

@jmlarson1
Copy link
Copy Markdown
Member

The PR: POptUS/IBCDFO#160 added a new exit flag for pounders/ibcdfo. If we encounter that in APOSMM using pounders as the localopt method, we'll still consider the point returned as a local min.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.33%. Comparing base (aa54e7d) to head (beddd74).
Report is 132 commits behind head on develop.

Files with missing lines Patch % Lines
libensemble/gen_funcs/aposmm_localopt_support.py 50.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (aa54e7d) and HEAD (beddd74). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (aa54e7d) HEAD (beddd74)
26 12
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1436       +/-   ##
============================================
- Coverage    92.47%   77.33%   -15.14%     
============================================
  Files           85       85               
  Lines         7973     7973               
  Branches      1425     1425               
============================================
- Hits          7373     6166     -1207     
- Misses         399     1586     +1187     
- Partials       201      221       +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav jlnav merged commit 5771ea4 into develop Oct 7, 2024
@jmlarson1 jmlarson1 deleted the bugfix_ibcdfo_new_flag branch February 20, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants