Testing/some coverage + another attempt at dynamic versioning#1547
Testing/some coverage + another attempt at dynamic versioning#1547shuds13 merged 7 commits intorelease/v_1.5.0from
Conversation
…e attribute from the object. try the dynamic versioning again...
…ibensemble.gen_funcs.persistent_tasmanian import *
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v_1.5.0 #1547 +/- ##
===================================================
- Coverage 78.21% 69.79% -8.43%
===================================================
Files 76 77 +1
Lines 7694 7813 +119
Branches 1149 1156 +7
===================================================
- Hits 6018 5453 -565
- Misses 1477 2166 +689
+ Partials 199 194 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Format: ``<basename>_results_History_length=<length>_evals=<Completed evals>_ranks=<nworkers>`` | ||
| """ | ||
| if self.is_manager: | ||
| if self._get_option("libE_specs", "workflow_dir_path"): |
There was a problem hiding this comment.
I think this change should wait as its a code change post testing
| logger.manager_warning("LUMI detected, but no compute partition detected. Are you on login nodes?") | ||
| if partition and partition.endswith("-g"): | ||
| name = "lumi_g" | ||
| print(f"Lumi GPU detected: {name}") |
| from libensemble.tools import parse_args | ||
| from libensemble.tools.persistent_support import PersistentSupport | ||
|
|
||
| __all__ = [ |
There was a problem hiding this comment.
I dont think we should remove this- doesn't the docs read this
There was a problem hiding this comment.
I had to verify this when I was puzzling why that line wasn't covered before, but it turns out __all__ only gets covered when one does:
from some_module import *
This isn't done in our code, or the docs:
.. automodule:: persistent_tasmanian
:members: sparse_grid_batched, sparse_grid_async
:undoc-members:
2 participants
No description provided.