-
Notifications
You must be signed in to change notification settings - Fork 28
Feature/subsecond time #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jlnav Is it possible to replace the two uses of Thoughts? |
Good point. Fixed. |
|
I don't think this is working as expected. When I run, I get the following output: The time is not correct, and the |
|
It will be Not Set unless you are using the calc_status feature. I may be inclined to only write the milliseconds to file if run-times are smaller than some cut-off, as these lines can get very long - esp. if you include job run-times (as well as calc times). |
|
I'm also getting milliseconds only on my laptop (running forces test). |
|
Sorry about that. I think I just fixed the milliseconds-only issue. |
|
Yes, the time issue seems to be fixed now. |
shuds13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to pull this into develop. We may want to think about variable precision to output, maybe depending on runtimes. But that can be an optional follow up.
The Timer module now measures in milliseconds behind-the-scenes.
libE_statsdisplays additional millisecond values for Start and End times:Start: 2019-12-11 10:27:50.227 End: 2019-12-11 10:27:50.733However, for compatibility with current timing mechanisms
timer.elapsedandtimer.totaltimes are returned as seconds. If necessary, I can implement additional settings or parameters for milliseconds if we want to be more precise throughout the project.