Alexkaiqi #4
Merged
Alexkaiqi #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ../stylesheets/images/bg-ico.png reference to ../style/images/bg-ico.png
fix ../stylesheets/images/bg-ico.png to ../style/images/bg-ico.png
fix ../stylesheets/images/bg-ico.png to ../style/images/bg-ico.png
Contributor
Author
|
I found this is a great theme for me, it is simple and elegant. Thank you. |
It seems that you forgot to add <head> tag.
It seems you missed a </div> tag at the end. But I am not quite sure about this, due to its complexity.
Please be careful when try to pass this pull request.
I also find {{ page.content | strip_html | strip_newlines | truncate: 120 }} in your head.html does not work,
it translated to something like {% for post in site.posts %} {% capture this_year %}{{ post.date | date: "%Y" }}{% endcapture %} {% capture...". I tried to replace page.content variable, and it works. So I guess it is probably because page.content contains other liquid
syntax. But i don't know how to fix it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found there is reference error when referring to ../stylesheets/*. Maybe this is because you have changed your directory to ../style. I fixed three pages, and this is all I can find. Hope this fix is correct.