Skip to content

"all types" --> "most types"#153

Merged
emcaulay merged 2 commits intoLibraryCarpentry:mainfrom
ErinBecker:main
Oct 17, 2023
Merged

"all types" --> "most types"#153
emcaulay merged 2 commits intoLibraryCarpentry:mainfrom
ErinBecker:main

Conversation

@ErinBecker
Copy link
Copy Markdown
Contributor

The start of the "What is Git/GitHub" states that "modern version control systems can be used to track changes in any type of file" but later says "Since Word documents contain special formatting, Git unfortunately cannot version control those, nor can it version control PDFs, though both file types can be stored in Git repositories."

This PR changes "any type" to "most types" to avoid contradicting later information.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-git/compare/md-outputs..md-outputs-PR-153

The following changes were observed in the rendered markdown documents:

 01-what-is-git.md | 2 +-
 md5sum.txt        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-16 21:08:26 +0000

github-actions Bot pushed a commit that referenced this pull request Oct 16, 2023
Copy link
Copy Markdown
Contributor

@emcaulay emcaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent revision - thank yoU!

@emcaulay emcaulay merged commit 0eb4299 into LibraryCarpentry:main Oct 17, 2023
github-actions Bot pushed a commit that referenced this pull request Oct 17, 2023
Auto-generated via {sandpaper}
Source  : 0eb4299
Branch  : main
Author  : Elizabeth McAulay <stassewright@gmail.com>
Time    : 2023-10-17 19:20:39 +0000
Message : Merge pull request #153 from ErinBecker/main

"all types" --> "most types"
github-actions Bot pushed a commit that referenced this pull request Oct 17, 2023
Auto-generated via {sandpaper}
Source  : 45c8e8a
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-17 19:21:52 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0eb4299
Branch  : main
Author  : Elizabeth McAulay <stassewright@gmail.com>
Time    : 2023-10-17 19:20:39 +0000
Message : Merge pull request #153 from ErinBecker/main

"all types" --> "most types"
@ErinBecker
Copy link
Copy Markdown
Contributor Author

Thanks for the fast review @emcaulay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants