Correct typo#83
Closed
wood-chris wants to merge 1 commit intoLibraryCarpentry:gh-pagesfrom
Closed
Conversation
`-(N-1)` is not correct. Given a string, `s = 'cow'`, which has 3 elements: `len(s)` => 3 `s[-1]` => 'w' `s[-3]` => 'c' - the first element `s[-(3-1)]` => 'o', which is not the first element (but the lesson says it is)
Contributor
Author
Member
|
Thanks, @wood-chris. I agree - this is wrong and you fix is correct. I will just get the confirmation of the other maintainer to merge you PR. |
Member
|
This was fixed in #76 which I justed merged. Still, many thanks @wood-chris. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-(N-1)is not correct. Given a string,s = 'cow', which has 3 elements:len(s)=> 3s[-1]=> 'w's[-3]=> 'c' - the first elements[-(3-1)]=> 'o', which is not the first element (but the lesson says it is)