Skip to content

Conversation

@bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Nov 18, 2025

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

NA

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Use filename instead of file as the iteration varibale name in the loops section

If any relevant discussions have taken place elsewhere, please provide links to these.

#259 (comment)

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

github-actions bot pushed a commit that referenced this pull request Nov 18, 2025
github-actions bot pushed a commit that referenced this pull request Nov 21, 2025
@morskyjezek
Copy link
Contributor

The variable filename also conforms to the example earlier in the lesson.

@morskyjezek morskyjezek merged commit c2c2fb4 into LibraryCarpentry:main Nov 24, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 24, 2025
Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions bot pushed a commit that referenced this pull request Nov 24, 2025
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
github-actions bot pushed a commit that referenced this pull request Nov 25, 2025
Auto-generated via `{sandpaper}`
Source  : ce69a15
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-24 12:18:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c2c2fb4
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2025-11-24 12:17:19 +0000
Message : Merge pull request #290 from bkmgit/patch-5

Use clearer variable name
@bkmgit bkmgit deleted the patch-5 branch November 25, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants