Merged
Conversation
Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Windows binaries are digitally signed in order to avoid the yellow big warning during install, and to avoid install stop in enterprises with strong security policies forbidding unsigned packages.
recently, code signing industry standards requires private keys for standard code signing certificates to be stored on hardware certified as FIPS 140 Level 2, which prevent us to use a software key stored on the compilation machine, we need to split the build process in a compilation phase, a signature phase and a release phase.